fix: availability can be read after close

Signed-off-by: Kevin Viglucci <[email protected]>

Author: viglucci

packages/rsocket-websocket-server/src/WebsocketDuplexConnection.ts

@@ -55,7 +55,7 @@ export class WebsocketDuplexConnection
   }
 
   get availability(): number {
-    return this.websocketDuplex.destroyed ? 0 : 1;
+    return this.done ? 0 : 1;
   }
 
   close(error?: Error) {

packages/rsocket-websocket-server/src/__tests__/WebsocketDuplexConnection.spec.ts

@@ -177,6 +177,26 @@ describe("WebsocketDuplexConnection", function () {
         new Error("WebsocketDuplexConnection: Socket closed unexpectedly.")
       );
     });
+
+    it("declares availability as 0", () => {
+      // arrange
+      const socketStub = mock<Duplex>();
+      const multiplexerDemultiplexer = mock<
+        Multiplexer & Demultiplexer & FrameHandler
+      >();
+      const frame = mock<Frame>();
+      const connection = new WebsocketDuplexConnection(
+        socketStub,
+        frame,
+        () => multiplexerDemultiplexer
+      );
+
+      // act
+      connection.close();
+
+      // assert
+      expect(connection.availability).toEqual(0);
+    });
   });
 
   // describe("send()", () => {