Skip to content

Commit 4783c90

Browse files
committed
Cut 1.26.1
1 parent d3f1806 commit 4783c90

File tree

6 files changed

+22
-5
lines changed

6 files changed

+22
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
## master (unreleased)
1313

14+
## 1.26.1 (2025-10-18)
15+
1416
### Bug fixes
1517

1618
* [#517](https://github.com/rubocop/rubocop-performance/issues/517): Fix false positives for `Performance/RedundantStringChars` when using `str.chars[0, 2]`. ([@koic][])

config/default.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Performance/BigDecimalWithNumericArgument:
2424
Description: 'Convert numeric literal to string and pass it to `BigDecimal`.'
2525
Enabled: false
2626
VersionAdded: '1.7'
27-
VersionChanged: <<next>>
27+
VersionChanged: '1.26'
2828

2929
Performance/BindCall:
3030
Description: 'Use `bind_call(obj, args, ...)` instead of `bind(obj).call(args, ...)`.'

docs/antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ name: rubocop-performance
22
title: RuboCop Performance
33
# We always provide version without patch here (e.g. 1.1),
44
# as patch versions should not appear in the docs.
5-
version: ~
5+
version: '1.26'
66
nav:
77
- modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_performance.adoc

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ NOTE: Requires Ruby version 3.1
9797
|===
9898
| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
9999
100-
| Pending
100+
| Disabled
101101
| Yes
102102
| Always
103103
| 1.7
104-
| -
104+
| 1.26
105105
|===
106106
107107
Identifies places where a float argument to BigDecimal should be converted to a string.
@@ -110,6 +110,11 @@ Initializing from String is faster than from Float for BigDecimal.
110110
Also identifies places where an integer string argument to BigDecimal should be converted to
111111
an integer. Initializing from Integer is faster than from String for BigDecimal.
112112
113+
NOTE: This cop is disabled by default because the performance of initializing with a String
114+
and Number differ between versions. Additionally, performance depends on the size of the Number,
115+
and if it is an Integer or a Float. Since this is very specific to `bigdecimal` internals,
116+
suggestions from this cop are not unlikely to result in code that performs worse than before.
117+
113118
[#examples-performancebigdecimalwithnumericargument]
114119
=== Examples
115120

lib/rubocop/performance/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module RuboCop
44
module Performance
55
# This module holds the RuboCop Performance version information.
66
module Version
7-
STRING = '1.26.0'
7+
STRING = '1.26.1'
88

99
def self.document_version
1010
STRING.match('\d+\.\d+').to_s

relnotes/v1.26.1.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
### Bug fixes
2+
3+
* [#517](https://github.com/rubocop/rubocop-performance/issues/517): Fix false positives for `Performance/RedundantStringChars` when using `str.chars[0, 2]`. ([@koic][])
4+
5+
### Changes
6+
7+
* [#520](https://github.com/rubocop/rubocop-performance/issues/520): Disable `Performance/BigDecimalWithNumericArgument` by default. ([@earlopain][])
8+
9+
[@koic]: https://github.com/koic
10+
[@earlopain]: https://github.com/earlopain

0 commit comments

Comments
 (0)