Add Danger (#1455)

Author: orta

.rubocop.yml

@@ -1,4 +1,7 @@
 AllCops:
+  Include:
+    - Dangerfile
+
   Exclude:
     - vendor/**/*
     - bin/**/*

.travis.yml

@@ -23,3 +23,6 @@ gemfile:
   - gemfiles/rack_1.5.2.gemfile
 
 bundler_args: --without development
+
+before_script:
+  - bundle exec danger

CHANGELOG.md

@@ -5,10 +5,12 @@
 
 * [#1440](https://github.com/ruby-grape/grape/pull/1441): Supports only Ruby 2.2.2 and later - [@jlfaber](https://github.com/jlfaber).
 * [#1393](https://github.com/ruby-grape/grape/pull/1393): Middleware can be inserted before or after default Grape middleware - [@ridiculous](https://github.com/ridiculous).
-* [#1390](https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@Rosa](https://github.com/Rosa).
-* [#1366](https://github.com/ruby-grape/grape/pull/1366): Store `message_key` on `Grape::Exceptions::Validation` - [@mkou](https://github.com/mkou).
-* [#1398](https://github.com/ruby-grape/grape/pull/1398): Added `rescue_from :grape_exceptions` - allow Grape to use the built-in `Grape::Exception` handing and use `rescue :all` behavior for everything else - [@mmclead](https://github.com/mmclead).
-* [#1443](https://github.com/ruby-grape/grape/pull/1443): Extended `given` to receive a `Proc` - [@glaucocustodio](https://github.com/glaucocustodio).
+* [#1390](https://github.com/ruby-grape/grape/pull/1390): Allows inserting middleware at arbitrary points in the middleware stack - [@Rosa](https://github.com/Rosa).
+* [#1366](https://github.com/ruby-grape/grape/pull/1366): Stores `message_key` on `Grape::Exceptions::Validation` - [@mkou](https://github.com/mkou).
+* [#1398](https://github.com/ruby-grape/grape/pull/1398): Adds `rescue_from :grape_exceptions` - allow Grape to use the built-in `Grape::Exception` handing and use `rescue :all` behavior for everything else - [@mmclead](https://github.com/mmclead).
+* [#1443](https://github.com/ruby-grape/grape/pull/1443): Extends `given` to receive a `Proc` - [@glaucocustodio](https://github.com/glaucocustodio).
+* [#1455](https://github.com/ruby-grape/grape/pull/1455): Adds an automated PR linter - [@orta](https://github.com/orta).
+
 * Your contribution here.
 
 #### Fixes

Dangerfile

@@ -0,0 +1,25 @@
+# Has any changes happened inside the lib dir?
+has_app_changes = !git.modified_files.grep(/lib/).empty?
+
+if git.modified_files.include?('CHANGELOG.md') == false && !declared_trivial && has_app_changes
+  pr_number = github.pr_json['number']
+  markdown <<-MARKDOWN
+Here's an example of your CHANGELOG entry:
+
+```markdown
+* [##{pr_number}](https://github.com/ruby-grape/grape/pull/#{pr_number}): #{github.pr_title} - [@#{github.pr_author}](https://github.com/#{github.pr_author}).
+```
+  fail('No CHANGELOG changes made in CHANGELOG.md when there are library changes.', sticky: false)
+MARKDOWN
+end
+
+# Don't let testing shortcuts get into master by accident,
+# ensuring that we don't get green builds based on a subset of tests.
+(git.modified_files + git.added_files - %w(Dangerfile)).each do |file|
+  next unless File.file?(file)
+  contents = File.read(file)
+  if file.start_with?('spec')
+    raise("`xit` or `fit` left in tests (#{file})") if contents =~ /^\w*[xf]it/
+    raise("`fdescribe` left in tests (#{file})") if contents =~ /^\w*fdescribe/
+  end
+end

Gemfile

@@ -28,4 +28,5 @@ group :test do
   gem 'cookiejar'
   gem 'rack-contrib'
   gem 'mime-types', '< 3.0'
+  gem 'danger', '~> 2.0'
 end

gemfiles/rack_1.5.2.gemfile

@@ -28,6 +28,7 @@ group :test do
   gem 'cookiejar'
   gem 'rack-contrib'
   gem 'mime-types', '< 3.0'
+  gem 'danger', '~> 2.0'
 end
 
 gemspec path: '../'

gemfiles/rails_3.gemfile

@@ -29,6 +29,7 @@ group :test do
   gem 'cookiejar'
   gem 'rack-contrib'
   gem 'mime-types', '< 3.0'
+  gem 'danger', '~> 2.0'
 end
 
 gemspec path: '../'

gemfiles/rails_4.gemfile

@@ -28,6 +28,7 @@ group :test do
   gem 'cookiejar'
   gem 'rack-contrib'
   gem 'mime-types', '< 3.0'
+  gem 'danger', '~> 2.0'
 end
 
 gemspec path: '../'