Skip to content

Add test for verifiable certificate #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jch opened this issue Dec 3, 2014 · 2 comments
Closed

Add test for verifiable certificate #169

jch opened this issue Dec 3, 2014 · 2 comments

Comments

@jch
Copy link
Member

jch commented Dec 3, 2014

See 79aefff for background.
jch referenced this issue Dec 3, 2014
@mtodd
Skip cert verification for test
79aefff 
cc @jch as I'm unsure if we want to go this route or make the cert verifiable instead
@mtodd
Copy link
Member

mtodd commented Dec 4, 2014

@jch check out the followup commit which reverted that change in favor of verifying against a specific CA file. Sorry about the confusion, I'd changed direction after committing that and realizing that ca_file was a valid option and solved the immediate problem.

It might make sense to add a test in addition to the existing test to make sure that VERIFY_NONE works as expected, but that's different than what this issue indicates as needed.

@mtodd
Copy link
Member

mtodd commented Dec 10, 2014

Going to close this because #166 should address this need.

@mtodd mtodd closed this as completed Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtodd @jch