You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Negation globs seemingly don't work. For example, I can't do something like this:
- '!(workspaces)/**/sourcing/**/*'
to say that I want this team to own any folder that has a "sourcing" subfolder in the path, but not within any "workspaces" folders.
This works just fine when tested with compgen. code_ownership doesn't seem to throw an error when validating, but when checking a path that should be owned under that glob, say lib/sourcing/some_file.rb, it incorrect states that it's not owned. Interestingly, it still correctly updates the CODEOWNERS file with the negation glob.
So now, instead of having single glob that covers most of this team's ownership, I will have to explicitly map out each folder instead.
The text was updated successfully, but these errors were encountered:
Hi @mscrivo! Thanks for filing this issue. You're correct, currently code_ownership does not support this syntax, and there is that limitation with Dir.glob. One way to add support for excluding globs would be to add an unowned_globs array for teams. We would welcome this contribution if you'd like to make a pull request!
Negation globs seemingly don't work. For example, I can't do something like this:
to say that I want this team to own any folder that has a "sourcing" subfolder in the path, but not within any "workspaces" folders.
This works just fine when tested with
compgen
.code_ownership
doesn't seem to throw an error when validating, but when checking a path that should be owned under that glob, saylib/sourcing/some_file.rb
, it incorrect states that it's not owned. Interestingly, it still correctly updates theCODEOWNERS
file with the negation glob.So now, instead of having single glob that covers most of this team's ownership, I will have to explicitly map out each folder instead.
The text was updated successfully, but these errors were encountered: