Skip to content

Commit 7d3c19b

Browse files
perryqhclaude
andcommitted
docs(ci): note that codesign --sign - needs no certificate
A reviewer read `codesign --force --sign -` and asked where the signing certificate comes from. The surrounding comment explained why the re-sign happens but never said what `-` is, so the flag reads like a placeholder for an identity name that CI must provision. It is the ad-hoc identity: no certificate, no keychain, no Developer ID. Confirmed against the built artifact, which reports `Signature=adhoc` and `TeamIdentifier=not set`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 41b28a1 commit 7d3c19b

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,12 @@ jobs:
150150
# single coherent signature. All code on Apple silicon must be at
151151
# least ad-hoc signed or it is SIGKILLed on launch, so verify rather
152152
# than assume. https://developer.apple.com/forums/thread/708552
153+
#
154+
# `--sign -` is the ad-hoc identity, not a placeholder for a cert
155+
# name: no certificate, no keychain, no Developer ID, nothing to
156+
# provision in CI. It only makes the binary internally consistent and
157+
# asserts nothing about who built it -- provenance comes from the
158+
# attestation step below, not from codesign.
153159
codesign --force --sign - target/codeowners
154160
codesign --verify --verbose target/codeowners
155161

0 commit comments

Comments
 (0)