update tests to use different fixtures

Author: ashleywillard

src/packs/configuration.rs

@@ -470,7 +470,7 @@ mod tests {
 
     #[test]
     fn with_readme_template_path() {
-        let absolute_root = PathBuf::from("tests/fixtures/simple_packs_first_app");
+        let absolute_root = PathBuf::from("tests/fixtures/app_with_custom_readme");
         let actual = configuration::get(&absolute_root).unwrap();
 
         let actual_readme_template_path = actual.readme_template_path;

tests/common/mod.rs

@@ -32,11 +32,22 @@ pub fn delete_foobar() {
 }
 
 #[allow(dead_code)]
-pub fn delete_foobar_packs_first() {
-    let directory = PathBuf::from("tests/fixtures/simple_packs_first_app/packs/foobar");
+pub fn delete_foobaz() {
+    let directory = PathBuf::from("tests/fixtures/simple_packs_first_app/packs/foobaz");
     if let Err(err) = fs::remove_dir_all(directory) {
         eprintln!(
-            "Failed to remove tests/fixtures/simple_packs_first_app/packs/foobar during test teardown: {}",
+            "Failed to remove tests/fixtures/simple_packs_first_app/packs/foobaz during test teardown: {}",
+            err
+        );
+    }
+}
+
+#[allow(dead_code)]
+pub fn delete_foobar_app_with_custom_readme() {
+    let directory = PathBuf::from("tests/fixtures/app_with_custom_readme/packs/foobar");
+    if let Err(err) = fs::remove_dir_all(directory) {
+        eprintln!(
+            "Failed to remove tests/fixtures/app_with_custom_readme/packs/foobar during test teardown: {}",
             err
         );
     }

tests/create_test.rs

@@ -68,40 +68,40 @@ See https://github.com/rubyatscale/pks#readme for more info!");
 
 #[test]
 fn test_create_with_readme_template_default_path() -> Result<(), Box<dyn Error>> {
-    common::delete_foobar();
+    common::delete_foobaz();
 
-    fs::write("tests/fixtures/simple_app/README_TEMPLATE.md", "This is a test custom README template")?;
+    fs::write("tests/fixtures/simple_packs_first_app/README_TEMPLATE.md", "This is a test custom README template")?;
 
     Command::cargo_bin("pks")?
         .arg("--project-root")
-        .arg("tests/fixtures/simple_app")
+        .arg("tests/fixtures/simple_packs_first_app")
         .arg("create")
-        .arg("packs/foobar")
+        .arg("packs/foobaz")
         .assert()
         .success();
 
     let expected_readme = String::from("This is a test custom README template");
     let actual_readme =
-        fs::read_to_string("tests/fixtures/simple_app/packs/foobar/README.md").unwrap_or_else(|e| {
-            panic!("Could not read file tests/fixtures/simple_app/packs/foobar/README.md: {}", e)
+        fs::read_to_string("tests/fixtures/simple_packs_first_app/packs/foobaz/README.md").unwrap_or_else(|e| {
+            panic!("Could not read file tests/fixtures/simple_packs_first_app/packs/foobaz/README.md: {}", e)
         });
 
     assert_eq!(expected_readme, actual_readme);
 
     common::teardown();
-    common::delete_foobar();
-    fs::remove_file("tests/fixtures/simple_app/README_TEMPLATE.md")?;
+    common::delete_foobaz();
+    fs::remove_file("tests/fixtures/simple_packs_first_app/README_TEMPLATE.md")?;
 
     Ok(())
 }
 
 #[test]
 fn test_create_with_readme_template_custom_path() -> Result<(), Box<dyn Error>> {
-    common::delete_foobar_packs_first();
+    common::delete_foobar_app_with_custom_readme();
 
     Command::cargo_bin("pks")?
         .arg("--project-root")
-        .arg("tests/fixtures/simple_packs_first_app")
+        .arg("tests/fixtures/app_with_custom_readme")
         .arg("create")
         .arg("packs/foobar")
         .assert()
@@ -110,14 +110,14 @@ fn test_create_with_readme_template_custom_path() -> Result<(), Box<dyn Error>>
     let expected_readme = String::from("README template\n\nThis is a test\n");
 
     let actual_readme =
-        fs::read_to_string("tests/fixtures/simple_packs_first_app/packs/foobar/README.md").unwrap_or_else(|e| {
-            panic!("Could not read file tests/fixtures/simple_packs_first_app/packs/foobar/README.md: {}", e)
+        fs::read_to_string("tests/fixtures/app_with_custom_readme/packs/foobar/README.md").unwrap_or_else(|e| {
+            panic!("Could not read file tests/fixtures/app_with_custom_readme/packs/foobar/README.md: {}", e)
         });
 
     assert_eq!(expected_readme, actual_readme);
 
     common::teardown();
-    common::delete_foobar_packs_first();
+    common::delete_foobar_app_with_custom_readme();
 
     Ok(())
 }

tests/fixtures/app_with_custom_readme/app/services/some_root_class.rb

@@ -0,0 +1 @@
+class SomeRootClass; end

tests/fixtures/simple_packs_first_app/config/packs/README_EXAMPLE.md renamed to tests/fixtures/app_with_custom_readme/config/packs/README_EXAMPLE.md

@@ -0,0 +1,25 @@
+# See: Setting up the configuration file
+# https://github.com/Shopify/packwerk/blob/main/USAGE.md#setting-up-the-configuration-file
+
+# List of patterns for folder paths to include
+# include:
+# - "**/*.{rb,rake,erb}"
+
+# List of patterns for folder paths to exclude
+# exclude:
+# - "{bin,node_modules,script,tmp,vendor}/**/*"
+
+# Patterns to find package configuration files
+# package_paths: "**/"
+
+# List of custom associations, if any
+# custom_associations:
+# - "cache_belongs_to"
+
+# Whether or not you want the cache enabled (disabled by default)
+cache: false
+
+# Where you want the cache to be stored (default below)
+# cache_directory: 'tmp/cache/packwerk'
+
+readme_template_path: config/packs/README_EXAMPLE.md

tests/fixtures/app_with_custom_readme/package.yml

@@ -0,0 +1 @@
+module SomeConcern; end

tests/fixtures/app_with_custom_readme/packs.yml

@@ -0,0 +1,3 @@
+module Bar
+  def bar; end
+end

tests/fixtures/app_with_custom_readme/packs/bar/app/models/concerns/some_concern.rb

@@ -0,0 +1 @@
+enforce_privacy: true