Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blacklist for reserved gem names #1156

Merged
merged 1 commit into from
Dec 28, 2015
Merged

Conversation

dwradcliffe
Copy link
Member

I started with the list from that issue. Are there any other names we want to add to the list?

Fixes: #1155

review: @indirect @qrush @sferik @arthurnn

@sferik
Copy link
Member

sferik commented Dec 28, 2015

👍

@qrush
Copy link
Member

qrush commented Dec 28, 2015

May I also suggest:

  • rbconfig
  • rubygems
  • ubygems 😒
  • unicode_normalize
  • tk
  • win32ole

Pulled a few of these from some greps of lib in ruby trunk.

Also need to #destroy any of these that exist, could use a little task for that. (Do any exist already beyond openssl? We should notify those gem authors if so!) Or could just do it console after deploy, your call!

@dwradcliffe
Copy link
Member Author

Added a few more. I'm going to ship this as is and we can remove the existing gems in a second PR.

dwradcliffe added a commit that referenced this pull request Dec 28, 2015
@dwradcliffe dwradcliffe merged commit c95ce60 into master Dec 28, 2015
@dwradcliffe dwradcliffe deleted the blacklist_reserved_names branch December 28, 2015 17:08
@arthurnn
Copy link
Member

arthurnn commented Jan 4, 2016

👍

@ajb
Copy link

ajb commented Feb 6, 2016

Looks like this is the cause of rubygems/rubygems#1474.

I understand the impetus behind this PR, but as a gem maintainer, it would have been nice to have a heads-up. We're aware that Sync is already a module in the stdlib, but nobody has been able to dedicate the effort to renaming the gem.

we can remove the existing gems in a second PR.

This obviously hasn't happened yet... but are there any details on what this will look like? Will folks' deployments start breaking suddenly?

@arthurnn
Copy link
Member

arthurnn commented Feb 8, 2016

@ajb thanks for letting us know about the issue. I will talk to the team and get back to you with a solution.
Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants