web: Use static observedAttributes in player attributeChangedCallback

danielhjacobs · web-flow · commit d7da115cbf44 · 2024-12-27T18:08:25.000-05:00
diff --git a/web/packages/core/src/internal/player/ruffle-player-element.tsx b/web/packages/core/src/internal/player/ruffle-player-element.tsx
@@ -84,7 +84,7 @@ export class RufflePlayerElement extends HTMLElement implements PlayerElement {
         _oldValue: string | undefined,
         _newValue: string | undefined,
     ): void {
-        if (name === "width" || name === "height" || name === "align") {
+        if (RufflePlayerElement.observedAttributes.includes(name)) {
             this.#inner.updateStyles();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export class RufflePlayerElement extends HTMLElement implements PlayerElement {`
`84`	`84`	`_oldValue: string \| undefined,`
`85`	`85`	`_newValue: string \| undefined,`
`86`	`86`	`): void {`
`87`		`- if (name === "width" \|\| name === "height" \|\| name === "align") {`
	`87`	`+ if (RufflePlayerElement.observedAttributes.includes(name)) {`
`88`	`88`	`this.#inner.updateStyles();`
`89`	`89`	`}`
`90`	`90`	`}`