Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Metric Aggregation [MetricFamilies MUST NOT be interleaved.] #45

Open
maurisource opened this issue Feb 12, 2025 · 3 comments

Comments

@maurisource
Copy link

So I'm working with the latest version of the module in Adobe Commerce 2.4.7-p1 with Php 8.3.

I face an issue with the following metrics I tested:

TYPE magento_orders_count_total gauge

I've generated the DB with the CLI command: run_as_root:metric:collect

I processed 2 new orders state and perform the Metric Collect command again.

Image

The problem is that the aggregated metrics at the end of file, are being discarded from Prometheus.
Shouldn't those new lines be within # TYPE magento_orders_count_total gauge ?

@maurisource
Copy link
Author

Hello @DavidLambauer
There's a bug in your module which fails this OpenMetrics basic principle here:
MetricFamilies MUST NOT be interleaved.

Are you able to fix it from your end?

@maurisource maurisource changed the title Issue with Metric Aggregation Issue with Metric Aggregation [MetricFamilies MUST NOT be interleaved.] Feb 19, 2025
@DavidLambauer
Copy link
Member

Hey @maurisource,

thank you for your patience. We'll look at this issue and plan it internally.

@maurisource
Copy link
Author

Thanks for responding @DavidLambauer
Can you let me know if you were able to replicate? Will be tracking this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants