Merge pull request #237 from matthiasbeyer/fix-nightly-clippy

Fix nightly clippy issues

Author: matthiasbeyer

src/builder.rs

@@ -120,11 +120,7 @@ pub struct DefaultState {
 ///
 /// Refer to [`ConfigBuilder`] for similar API sample usage or to the examples folder of the crate, where such a source is implemented.
 #[derive(Debug, Clone, Default)]
-pub struct AsyncConfigBuilder {
-    defaults: Map<Expression, Value>,
-    overrides: Map<Expression, Value>,
-    sources: Vec<SourceType>,
-}
+pub struct AsyncConfigBuilder {}
 
 /// Represents data specific to builder in asychronous state, with support for async.
 #[derive(Debug, Default)]

src/env.rs

@@ -5,7 +5,7 @@ use crate::map::Map;
 use crate::source::Source;
 use crate::value::{Value, ValueKind};
 
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Default)]
 pub struct Environment {
     /// Optional prefix that will limit access to the environment to only keys that
     /// begin with the defined prefix.
@@ -63,17 +63,6 @@ impl Environment {
     }
 }
 
-impl Default for Environment {
-    fn default() -> Environment {
-        Environment {
-            prefix: None,
-            separator: None,
-            ignore_empty: false,
-            try_parsing: false,
-        }
-    }
-}
-
 impl Source for Environment {
     fn clone_into_box(&self) -> Box<dyn Source + Send + Sync> {
         Box::new((*self).clone())

src/path/mod.rs

@@ -193,7 +193,7 @@ impl Expression {
                 match value.kind {
                     ValueKind::Table(ref incoming_map) => {
                         // Pull out another table
-                        let mut target = if let ValueKind::Table(ref mut map) = root.kind {
+                        let target = if let ValueKind::Table(ref mut map) = root.kind {
                             map.entry(id.clone())
                                 .or_insert_with(|| Map::<String, Value>::new().into())
                         } else {
@@ -202,7 +202,7 @@ impl Expression {
 
                         // Continue the deep merge
                         for (key, val) in incoming_map {
-                            Expression::Identifier(key.clone()).set(&mut target, val.clone());
+                            Expression::Identifier(key.clone()).set(target, val.clone());
                         }
                     }