Skip to content

Commit da83c02

Browse files
committed
Rename serial trait methods try_*
1 parent b5ad852 commit da83c02

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

src/blocking/serial.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ pub mod write {
4040

4141
fn try_bwrite_all(&mut self, buffer: &[Word]) -> Result<(), Self::Error> {
4242
for word in buffer {
43-
block!(self.write(word.clone()))?;
43+
block!(self.try_write(word.clone()))?;
4444
}
4545

4646
Ok(())
4747
}
4848

4949
fn try_bflush(&mut self) -> Result<(), Self::Error> {
50-
block!(self.flush())?;
50+
block!(self.try_flush())?;
5151
Ok(())
5252
}
5353
}

src/fmt.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ where
1111
let _ = s
1212
.as_bytes()
1313
.into_iter()
14-
.map(|c| block!(self.write(Word::from(*c))))
14+
.map(|c| block!(self.try_write(Word::from(*c))))
1515
.last();
1616
Ok(())
1717
}

src/lib.rs

+17-17
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@
7575
//! type Error;
7676
//!
7777
//! /// Reads a single byte
78-
//! fn read(&mut self) -> nb::Result<u8, Self::Error>;
78+
//! fn try_read(&mut self) -> nb::Result<u8, Self::Error>;
7979
//!
8080
//! /// Writes a single byte
81-
//! fn write(&mut self, byte: u8) -> nb::Result<(), Self::Error>;
81+
//! fn try_write(&mut self, byte: u8) -> nb::Result<(), Self::Error>;
8282
//! }
8383
//! ```
8484
//!
@@ -150,7 +150,7 @@
150150
//! impl hal::serial::Read<u8> for Serial<USART1> {
151151
//! type Error = Error;
152152
//!
153-
//! fn read(&mut self) -> nb::Result<u8, Error> {
153+
//! fn try_read(&mut self) -> nb::Result<u8, Error> {
154154
//! // read the status register
155155
//! let isr = self.usart.isr.read();
156156
//!
@@ -172,13 +172,13 @@
172172
//! impl hal::serial::Write<u8> for Serial<USART1> {
173173
//! type Error = Error;
174174
//!
175-
//! fn write(&mut self, byte: u8) -> nb::Result<(), Error> {
176-
//! // Similar to the `read` implementation
175+
//! fn try_write(&mut self, byte: u8) -> nb::Result<(), Error> {
176+
//! // Similar to the `try_read` implementation
177177
//! # Ok(())
178178
//! }
179179
//!
180-
//! fn flush(&mut self) -> nb::Result<(), Error> {
181-
//! // Similar to the `read` implementation
180+
//! fn try_flush(&mut self) -> nb::Result<(), Error> {
181+
//! // Similar to the `try_read` implementation
182182
//! # Ok(())
183183
//! }
184184
//! }
@@ -281,7 +281,7 @@
281281
//! {
282282
//! let mut serial = Some(serial);
283283
//! future::poll_fn(move || {
284-
//! let byte = try_nb!(serial.as_mut().unwrap().read());
284+
//! let byte = try_nb!(serial.as_mut().unwrap().try_read());
285285
//!
286286
//! Ok(Async::Ready((serial.take().unwrap(), byte)))
287287
//! })
@@ -296,7 +296,7 @@
296296
//! {
297297
//! let mut serial = Some(serial);
298298
//! future::poll_fn(move || {
299-
//! try_nb!(serial.as_mut().unwrap().write(byte));
299+
//! try_nb!(serial.as_mut().unwrap().try_write(byte));
300300
//!
301301
//! Ok(Async::Ready(serial.take().unwrap()))
302302
//! })
@@ -361,12 +361,12 @@
361361
//! # pub struct Serial1;
362362
//! # impl ::hal::serial::Read<u8> for Serial1 {
363363
//! # type Error = Infallible;
364-
//! # fn read(&mut self) -> ::nb::Result<u8, Infallible> { Err(::nb::Error::WouldBlock) }
364+
//! # fn try_read(&mut self) -> ::nb::Result<u8, Infallible> { Err(::nb::Error::WouldBlock) }
365365
//! # }
366366
//! # impl ::hal::serial::Write<u8> for Serial1 {
367367
//! # type Error = Infallible;
368-
//! # fn flush(&mut self) -> ::nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
369-
//! # fn write(&mut self, _: u8) -> ::nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
368+
//! # fn try_flush(&mut self) -> ::nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
369+
//! # fn try_write(&mut self, _: u8) -> ::nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
370370
//! # }
371371
//! #
372372
//! # pub struct Led;
@@ -492,7 +492,7 @@
492492
//! S: hal::serial::Write<u8>
493493
//! {
494494
//! for &byte in buffer {
495-
//! block!(serial.write(byte))?;
495+
//! block!(serial.try_write(byte))?;
496496
//! }
497497
//!
498498
//! Ok(())
@@ -528,7 +528,7 @@
528528
//! timer.try_start(timeout).map_err(Error::TimedOut)?;
529529
//!
530530
//! loop {
531-
//! match serial.read() {
531+
//! match serial.try_read() {
532532
//! // raise error
533533
//! Err(nb::Error::Other(e)) => return Err(Error::Serial(e)),
534534
//! Err(nb::Error::WouldBlock) => {
@@ -608,7 +608,7 @@
608608
//! {
609609
//! loop {
610610
//! if let Some(byte) = cb.peek() {
611-
//! match serial.write(*byte) {
611+
//! match serial.try_write(*byte) {
612612
//! Err(nb::Error::Other(_)) => unreachable!(),
613613
//! Err(nb::Error::WouldBlock) => return,
614614
//! Ok(()) => {}, // keep flushing data
@@ -670,8 +670,8 @@
670670
//! # struct Serial1;
671671
//! # impl ::hal::serial::Write<u8> for Serial1 {
672672
//! # type Error = Infallible;
673-
//! # fn write(&mut self, _: u8) -> nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
674-
//! # fn flush(&mut self) -> nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
673+
//! # fn try_write(&mut self, _: u8) -> nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
674+
//! # fn try_flush(&mut self) -> nb::Result<(), Infallible> { Err(::nb::Error::WouldBlock) }
675675
//! # }
676676
//! # struct CircularBuffer;
677677
//! # impl CircularBuffer {

src/serial.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ pub trait Read<Word> {
1111
type Error;
1212

1313
/// Reads a single word from the serial interface
14-
fn read(&mut self) -> nb::Result<Word, Self::Error>;
14+
fn try_read(&mut self) -> nb::Result<Word, Self::Error>;
1515
}
1616

1717
/// Write half of a serial interface
@@ -20,8 +20,8 @@ pub trait Write<Word> {
2020
type Error;
2121

2222
/// Writes a single word to the serial interface
23-
fn write(&mut self, word: Word) -> nb::Result<(), Self::Error>;
23+
fn try_write(&mut self, word: Word) -> nb::Result<(), Self::Error>;
2424

2525
/// Ensures that none of the previously written words are still buffered
26-
fn flush(&mut self) -> nb::Result<(), Self::Error>;
26+
fn try_flush(&mut self) -> nb::Result<(), Self::Error>;
2727
}

0 commit comments

Comments
 (0)