From 40dc8caff952f3027d7d7de0074af121a285af09 Mon Sep 17 00:00:00 2001 From: Robin Mueller Date: Wed, 15 Jan 2025 17:19:45 +0100 Subject: [PATCH] more clippy fixes --- CHANGELOG.md | 2 ++ ci/svd2rust-regress/src/github.rs | 2 +- src/generate/peripheral.rs | 2 +- src/generate/register.rs | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 89cbd574..91612ace 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/). - Added lifetime ellision for `FieldWriter` where the explicit lifetimes are not necessary, which fixes the `clippy::needless_lifetimes` warning on rustc 1.84 - Some fixes for the `svd2rust-regress` tool and update of its documentation +- Other internal clippy fixes for `clippy::manual_div_ceil`, `clippy::nonminimal_bool` and + `clippy::needless_lifetimes` ## [v0.35.0] - 2024-11-12 diff --git a/ci/svd2rust-regress/src/github.rs b/ci/svd2rust-regress/src/github.rs index 1a5b0ecb..5dc68508 100644 --- a/ci/svd2rust-regress/src/github.rs +++ b/ci/svd2rust-regress/src/github.rs @@ -93,7 +93,7 @@ fn find_executable(dir: &Path, begins: &str) -> Result, anyhow:: .path() .extension() .is_some_and(|s| s == std::env::consts::EXE_EXTENSION)) - && !entry.path().extension().is_some_and(|s| s == "gz") + && entry.path().extension().is_none_or(|s| s != "gz") { Ok(Some(entry.path())) } else { diff --git a/src/generate/peripheral.rs b/src/generate/peripheral.rs index 40372906..5fd01178 100644 --- a/src/generate/peripheral.rs +++ b/src/generate/peripheral.rs @@ -411,7 +411,7 @@ impl FieldRegions { let mut indices = Vec::new(); let rbf_start = rbf.offset; - let rbf_end = rbf_start + (rbf.size + BITS_PER_BYTE - 1) / BITS_PER_BYTE; + let rbf_end = rbf_start + rbf.size.div_ceil(BITS_PER_BYTE); // The region that we're going to insert let mut new_region = Region { diff --git a/src/generate/register.rs b/src/generate/register.rs index 92322ebe..56e72472 100644 --- a/src/generate/register.rs +++ b/src/generate/register.rs @@ -519,7 +519,7 @@ pub enum EV<'a> { Derived(&'a EnumeratedValues, &'a EnumPath), } -impl<'a> EV<'a> { +impl EV<'_> { fn values(&self) -> &EnumeratedValues { match self { Self::New(e) | Self::Derived(e, _) => e,