Skip to content

Commit 1de08b1

Browse files
committed
Get rid of some usages of query_keys
Rustdoc documents these with the name of the type alias instead of normalizing them to the underlying type. Use associated types instead so that the generated docs for nightly-rustc are easier to read.
1 parent b537619 commit 1de08b1

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

compiler/rustc_query_impl/src/plumbing.rs

+6-7
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ macro_rules! define_queries {
246246

247247
// Create an eponymous constructor for each query.
248248
$(#[allow(nonstandard_style)] $(#[$attr])*
249-
pub fn $name<'tcx>(tcx: QueryCtxt<'tcx>, key: query_keys::$name<'tcx>) -> QueryStackFrame {
249+
pub fn $name<'tcx>(tcx: QueryCtxt<'tcx>, key: <queries::$name<'tcx> as QueryConfig>::Key) -> QueryStackFrame {
250250
let kind = dep_graph::DepKind::$name;
251251
let name = stringify!($name);
252252
// Disable visible paths printing for performance reasons.
@@ -348,7 +348,6 @@ macro_rules! define_queries {
348348
mod query_callbacks {
349349
use super::*;
350350
use rustc_middle::dep_graph::DepNode;
351-
use rustc_middle::ty::query::query_keys;
352351
use rustc_query_system::dep_graph::DepNodeParams;
353352
use rustc_query_system::query::{force_query, QueryDescription};
354353
use rustc_query_system::dep_graph::FingerprintStyle;
@@ -410,7 +409,7 @@ macro_rules! define_queries {
410409
let is_eval_always = is_eval_always!([$($modifiers)*]);
411410

412411
let fingerprint_style =
413-
<query_keys::$name<'_> as DepNodeParams<TyCtxt<'_>>>::fingerprint_style();
412+
<<queries::$name<'_> as QueryConfig>::Key as DepNodeParams<TyCtxt<'_>>>::fingerprint_style();
414413

415414
if is_anon || !fingerprint_style.reconstructible() {
416415
return DepKindStruct {
@@ -423,8 +422,8 @@ macro_rules! define_queries {
423422
}
424423

425424
#[inline(always)]
426-
fn recover<'tcx>(tcx: TyCtxt<'tcx>, dep_node: DepNode) -> Option<query_keys::$name<'tcx>> {
427-
<query_keys::$name<'_> as DepNodeParams<TyCtxt<'_>>>::recover(tcx, &dep_node)
425+
fn recover<'tcx>(tcx: TyCtxt<'tcx>, dep_node: DepNode) -> Option<<queries::$name<'tcx> as QueryConfig>::Key> {
426+
<<queries::$name<'_> as QueryConfig>::Key as DepNodeParams<TyCtxt<'_>>>::recover(tcx, &dep_node)
428427
}
429428

430429
fn force_from_dep_node(tcx: TyCtxt<'_>, dep_node: DepNode) -> bool {
@@ -475,7 +474,7 @@ macro_rules! define_queries_struct {
475474

476475
jobs: AtomicU64,
477476

478-
$($(#[$attr])* $name: QueryState<query_keys::$name<'tcx>>,)*
477+
$($(#[$attr])* $name: QueryState<<queries::$name<'tcx> as QueryConfig>::Key>,)*
479478
}
480479

481480
impl<'tcx> Queries<'tcx> {
@@ -530,7 +529,7 @@ macro_rules! define_queries_struct {
530529
&'tcx self,
531530
tcx: TyCtxt<'tcx>,
532531
span: Span,
533-
key: query_keys::$name<'tcx>,
532+
key: <queries::$name<'tcx> as QueryConfig>::Key,
534533
mode: QueryMode,
535534
) -> Option<query_stored::$name<'tcx>> {
536535
let qcx = QueryCtxt { tcx, queries: self };

0 commit comments

Comments
 (0)