Skip to content

Commit 6d746cd

Browse files
committed
Auto merge of rust-lang#125486 - michaelwoerister:v0-baseline-240524, r=<try>
[perf] Test performance with v0 symbol mangling scheme being the default With the wider ecosystem getting close to support the v0 mangling scheme and LLD as the default linker addressing v0's main performance issue, it is getting more likely that we can soon make v0 the default. This PR's purpose is to collect current performance numbers and also to serve as a baseline for gauging the performance impact of [MCP 737](rust-lang/compiler-team#737). v0 symbol mangling tracking issue: rust-lang#60705 r? `@ghost`
2 parents 4649877 + bb6e11f commit 6d746cd

7 files changed

+15
-14
lines changed

compiler/rustc_session/src/config.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@ impl Options {
11781178
}
11791179

11801180
pub fn get_symbol_mangling_version(&self) -> SymbolManglingVersion {
1181-
self.cg.symbol_mangling_version.unwrap_or(SymbolManglingVersion::Legacy)
1181+
self.cg.symbol_mangling_version.unwrap_or(SymbolManglingVersion::V0)
11821182
}
11831183
}
11841184

tests/assembly/closure-inherit-target-feature.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//@ ignore-sgx Tests incompatible with LVI mitigations
33
//@ assembly-output: emit-asm
44
// make sure the feature is not enabled at compile-time
5-
//@ compile-flags: -C opt-level=3 -C target-feature=-sse4.1 -C llvm-args=-x86-asm-syntax=intel
5+
//@ compile-flags: -C opt-level=3 -C target-feature=-sse4.1 -C llvm-args=-x86-asm-syntax=intel -Csymbol-mangling-version=legacy -Zunstable-options
66

77
#![feature(target_feature_11)]
88
#![crate_type = "rlib"]

tests/codegen/precondition-checks.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313

1414
use std::ptr::NonNull;
1515

16-
// CHECK-LABEL: ; core::ptr::non_null::NonNull<T>::new_unchecked
16+
// CHECK-LABEL: ; <core::ptr::non_null::NonNull<u8>>::new_unchecked
1717
// CHECK-NOT: call
1818
// CHECK: }
1919

2020
// CHECK-LABEL: @nonnull_new
2121
#[no_mangle]
2222
pub unsafe fn nonnull_new(ptr: *mut u8) -> NonNull<u8> {
23-
// CHECK: ; call core::ptr::non_null::NonNull<T>::new_unchecked
23+
// CHECK: ; call <core::ptr::non_null::NonNull<u8>>::new_unchecked
2424
unsafe {
2525
NonNull::new_unchecked(ptr)
2626
}

tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-drop-in-place.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Verifies that type metadata identifiers for drop functions are emitted correctly.
22
//
33
//@ needs-sanitizer-cfi
4-
//@ compile-flags: -Clto -Cno-prepopulate-passes -Copt-level=0 -Zsanitizer=cfi -Ctarget-feature=-crt-static
4+
//@ compile-flags: -Clto -Cno-prepopulate-passes -Copt-level=0 -Zsanitizer=cfi -Ctarget-feature=-crt-static -Csymbol-mangling-version=legacy -Zunstable-options
55

66
#![crate_type="lib"]
77

tests/crashes/118603.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
//@ known-bug: #118603
2-
//@ compile-flags: -Copt-level=0
2+
//@ compile-flags: -Copt-level=0 -Csymbol-mangling-version=legacy
33
// ignore-tidy-linelength
4+
//@ ignore-test
45

56
#![feature(generic_const_exprs)]
67
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
thread 'main' panicked at $DIR/short-ice-remove-middle-frames-2.rs:56:5:
22
debug!!!
33
stack backtrace:
4-
0: std::panicking::begin_panic
4+
0: std::panicking::begin_panic::<&str>
55
1: short_ice_remove_middle_frames_2::eight
6-
2: short_ice_remove_middle_frames_2::seven::{{closure}}
6+
2: short_ice_remove_middle_frames_2::seven::{closure#0}
77
[... omitted 3 frames ...]
88
3: short_ice_remove_middle_frames_2::fifth
9-
4: short_ice_remove_middle_frames_2::fourth::{{closure}}
9+
4: short_ice_remove_middle_frames_2::fourth::{closure#0}
1010
[... omitted 4 frames ...]
1111
5: short_ice_remove_middle_frames_2::first
1212
6: short_ice_remove_middle_frames_2::main
13-
7: core::ops::function::FnOnce::call_once
13+
7: <fn() as core::ops::function::FnOnce<()>>::call_once
1414
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
thread 'main' panicked at $DIR/short-ice-remove-middle-frames.rs:52:5:
22
debug!!!
33
stack backtrace:
4-
0: std::panicking::begin_panic
4+
0: std::panicking::begin_panic::<&str>
55
1: short_ice_remove_middle_frames::seven
66
2: short_ice_remove_middle_frames::sixth
7-
3: short_ice_remove_middle_frames::fifth::{{closure}}
7+
3: short_ice_remove_middle_frames::fifth::{closure#0}
88
[... omitted 4 frames ...]
99
4: short_ice_remove_middle_frames::second
10-
5: short_ice_remove_middle_frames::first::{{closure}}
10+
5: short_ice_remove_middle_frames::first::{closure#0}
1111
6: short_ice_remove_middle_frames::first
1212
7: short_ice_remove_middle_frames::main
13-
8: core::ops::function::FnOnce::call_once
13+
8: <fn() as core::ops::function::FnOnce<()>>::call_once
1414
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

0 commit comments

Comments
 (0)