Skip to content

Commit e9180d2

Browse files
committed
Revert "fix missing rustfmt and clippy for msi"
This reverts commit f5577a8.
1 parent 6f5e494 commit e9180d2

File tree

2 files changed

+2
-70
lines changed

2 files changed

+2
-70
lines changed

src/bootstrap/src/core/build_steps/dist.rs

+1-30
Original file line numberDiff line numberDiff line change
@@ -1644,8 +1644,6 @@ impl Step for Extended {
16441644
"rust-analyzer-preview".to_string()
16451645
} else if name == "clippy" {
16461646
"clippy-preview".to_string()
1647-
} else if name == "rustfmt" {
1648-
"rustfmt-preview".to_string()
16491647
} else if name == "miri" {
16501648
"miri-preview".to_string()
16511649
} else if name == "rustc-codegen-cranelift" {
@@ -1665,7 +1663,7 @@ impl Step for Extended {
16651663
prepare("cargo");
16661664
prepare("rust-analysis");
16671665
prepare("rust-std");
1668-
for tool in &["clippy", "rustfmt", "rust-analyzer", "rust-docs", "miri"] {
1666+
for tool in &["clippy", "rust-analyzer", "rust-docs", "miri"] {
16691667
if built_tools.contains(tool) {
16701668
prepare(tool);
16711669
}
@@ -1783,24 +1781,6 @@ impl Step for Extended {
17831781
.arg(etc.join("msi/remove-duplicates.xsl"))
17841782
.run(builder);
17851783
}
1786-
if built_tools.contains("rustfmt") {
1787-
command(&heat)
1788-
.current_dir(&exe)
1789-
.arg("dir")
1790-
.arg("rustfmt")
1791-
.args(heat_flags)
1792-
.arg("-cg")
1793-
.arg("RustFmtGroup")
1794-
.arg("-dr")
1795-
.arg("RustFmt")
1796-
.arg("-var")
1797-
.arg("var.RustFmtDir")
1798-
.arg("-out")
1799-
.arg(exe.join("RustFmtGroup.wxs"))
1800-
.arg("-t")
1801-
.arg(etc.join("msi/remove-duplicates.xsl"))
1802-
.run(builder);
1803-
}
18041784
if built_tools.contains("miri") {
18051785
command(&heat)
18061786
.current_dir(&exe)
@@ -1872,9 +1852,6 @@ impl Step for Extended {
18721852
if built_tools.contains("clippy") {
18731853
cmd.arg("-dClippyDir=clippy");
18741854
}
1875-
if built_tools.contains("rustfmt") {
1876-
cmd.arg("-dRustFmtDir=rustfmt");
1877-
}
18781855
if built_tools.contains("rust-docs") {
18791856
cmd.arg("-dDocsDir=rust-docs");
18801857
}
@@ -1901,9 +1878,6 @@ impl Step for Extended {
19011878
if built_tools.contains("clippy") {
19021879
candle("ClippyGroup.wxs".as_ref());
19031880
}
1904-
if built_tools.contains("rustfmt") {
1905-
candle("RustFmtGroup.wxs".as_ref());
1906-
}
19071881
if built_tools.contains("miri") {
19081882
candle("MiriGroup.wxs".as_ref());
19091883
}
@@ -1942,9 +1916,6 @@ impl Step for Extended {
19421916
if built_tools.contains("clippy") {
19431917
cmd.arg("ClippyGroup.wixobj");
19441918
}
1945-
if built_tools.contains("rustfmt") {
1946-
cmd.arg("RustFmtGroup.wixobj");
1947-
}
19481919
if built_tools.contains("miri") {
19491920
cmd.arg("MiriGroup.wixobj");
19501921
}

src/etc/installer/msi/rust.wxs

+1-40
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@
172172
<!-- tool-rust-docs-end -->
173173
<Directory Id="Cargo" Name="." />
174174
<Directory Id="Std" Name="." />
175-
<Directory Id="RustFmt" Name="." />
176-
<Directory Id="RustAnalyzer" Name="." />
177-
<Directory Id="Miri" Name="." />
178-
<Directory Id="Analysis" Name="." />
179-
<Directory Id="Clippy" Name="." />
180175
</Directory>
181176
</Directory>
182177

@@ -284,41 +279,7 @@
284279
<ComponentRef Id="PathEnvPerMachine" />
285280
<ComponentRef Id="PathEnvPerUser" />
286281
</Feature>
287-
<Feature Id="RustFmt"
288-
Title="Formatter for rust"
289-
Display="7"
290-
Level="1"
291-
AllowAdvertise="no">
292-
<ComponentGroupRef Id="RustFmtGroup" />
293-
</Feature>
294-
<Feature Id="Clippy"
295-
Title="Formatter and checker for rust"
296-
Display="8"
297-
Level="1"
298-
AllowAdvertise="no">
299-
<ComponentGroupRef Id="ClippyGroup" />
300-
</Feature>
301-
<Feature Id="Miri"
302-
Title="Soundness checker for rust"
303-
Display="9"
304-
Level="1"
305-
AllowAdvertise="no">
306-
<ComponentGroupRef Id="MiriGroup" />
307-
</Feature>
308-
<Feature Id="RustAnalyzer"
309-
Title="Analyzer for rust"
310-
Display="10"
311-
Level="1"
312-
AllowAdvertise="no">
313-
<ComponentGroupRef Id="RustAnalyzerGroup" />
314-
</Feature>
315-
<Feature Id="Analysis"
316-
Title="Analysis for rust"
317-
Display="11"
318-
Level="1"
319-
AllowAdvertise="no">
320-
<ComponentGroupRef Id="AnalysisGroup" />
321-
</Feature>
282+
322283
<UIRef Id="RustUI" />
323284
</Product>
324285
</Wix>

0 commit comments

Comments
 (0)