Skip to content

Compatibility broken with rust 1.41 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeroen opened this issue Mar 7, 2021 · 2 comments
Closed

Compatibility broken with rust 1.41 #412

jeroen opened this issue Mar 7, 2021 · 2 comments

Comments

@jeroen
Copy link

jeroen commented Mar 7, 2021

Not sure if this is considered important, otherwise feel free to close!

As of commit c27d7c5 this crate no longer compiles with the stock rustc 1.41 on the latest Debian releases. The compilation fails when compiling object-0.23.0.

error[E0658]: subslice patterns are unstable
   --> /tmp/Rtmp90SLnd/R.INSTALL204d8c202e2/gifski/src/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.23.0/src/read/mod.rs:162:41
    |
162 |             [0x7f, b'E', b'L', b'F', 1, ..] => FileKind::Elf32,
    |                                         ^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/62254

error[E0658]: subslice patterns are unstable
   --> /tmp/Rtmp90SLnd/R.INSTALL204d8c202e2/gifski/src/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.23.0/src/read/mod.rs:164:41
    |
164 |             [0x7f, b'E', b'L', b'F', 2, ..] => FileKind::Elf64,
    |                                         ^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/62254

error[E0658]: subslice patterns are unstable
   --> /tmp/Rtmp90SLnd/R.INSTALL204d8c202e2/gifski/src/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.23.0/src/read/mod.rs:166:38
    |
166 |             [0xfe, 0xed, 0xfa, 0xce, ..]
    |                                      ^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/62254

This had caught me a bit by surprise, and I had to do a hotfix release of my application to downgrade to backtrace 0.3.55 in order for it to work on Debian.

@philipc
Copy link
Contributor

philipc commented Mar 7, 2021

I'm not a maintainer for this crate, but I think that's fine, I was just surprised because your other comment said 1.43.1. See #211 (comment) regarding minimum rust version for this crate.

@alexcrichton
Copy link
Member

Thanks for the report, but this isn't considered a breaking change for this crate, so I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants