Skip to content

Commit 0f710f6

Browse files
committed
More review comments
1 parent 34d5a86 commit 0f710f6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

content/c-abi-changes-for-wasm32-unknown-unknown.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ additionally [leaks internal compiler implementation details][leak-details] of
1212
both the Rust compiler and LLVM. This will change in a future version of the
1313
Rust compiler and the [official C ABI][tool-conventions] will be used instead.
1414

15+
This post details some history behind this change and the rationale for why it's
16+
being announced here, but you can skip straight to ["Am I
17+
affected?"](#am-i-affected) as well.
18+
1519
[tool-conventions]: https://github.com/WebAssembly/tool-conventions/blob/main/BasicCABI.md
1620
[leak-details]: https://github.com/rust-lang/rust/issues/115666
1721

@@ -98,7 +102,7 @@ This will generate the following WebAssembly function:
98102

99103
Notably you can see here that the struct `Pair` was "splatted" into its two
100104
components so the actual `$pair_add` function takes two arguments, the `x` and
101-
`y` fields. The [tool-conventions], however [specifically says] that "other
105+
`y` fields. The [tool-conventions], however specifically says that "other
102106
struct[s] or union[s]" are passed indirectly, notably through memory. We can see
103107
this by compiling this C code:
104108

0 commit comments

Comments
 (0)