Skip to content

Commit 34a1a2d

Browse files
pnkfelixbjorn3
andauthored
Apply suggestions from code review
Co-authored-by: bjorn3 <[email protected]>
1 parent bcaecd1 commit 34a1a2d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

tests/cli.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use self::meta_build::{DeltaKind, InjectionPoint, Test, YearMonthDay};
2727
use self::which_temp::{WhichTempDir, WhichTempDirectory};
2828

2929
// These tests pass `--preserve` and `--access=github` because that is the best
30-
// way to try to enusre that the tests complete as quickly as possible.
30+
// way to try to ensure that the tests complete as quickly as possible.
3131

3232
pub const BASIC_TEST: Test = Test {
3333
crate_name: "cbr_test_cli_basic",
@@ -46,7 +46,7 @@ pub const FIXED_TEST: Test = Test {
4646
delta_kind: DeltaKind::Fix,
4747
};
4848

49-
// Ordnarily, I would put both of these tests into separate `#[test]` methods.
49+
// Ordinarily, I would put both of these tests into separate `#[test]` methods.
5050
// However, if you do that, then `cargo test` will run them in parallel, and you
5151
// end up with `cargo-bisect-rustc` racing to install the toolchains it
5252
// downloads.
@@ -83,7 +83,7 @@ where WhichTemp: WhichTempDirectory
8383
println!("Command output stderr for {}: \n```\n{}\n```", test.crate_name, stderr);
8484

8585
// The most basic check: does the output actually tell us about the
86-
// "reressing" commit.
86+
// "regressing" commit.
8787
let needle = format!("regression in {}", test.expected_sha());
8888
// println!("searching for {:?} in stdout: {:?} stderr: {:?}", needle, stdout, stderr);
8989
assert!(stderr.contains(&needle));

tests/cli/meta_build/included_build_suffix.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Strategy inspired by dtolnay/rustversion: run `rustc --version` at build time
2-
// to observe verison info.
2+
// to observe version info.
33
//
44
// (The dtolnay/rustversion is dual-licensed under APACHE/MIT as of January 2020.)
55

tests/ice.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const ICE_MAIN_RS: &'static str = std::include_str!("ice/included_main.rs");
1919
//
2020
// In the long term, since we only store binaries over a fixed length of time,
2121
// this test will need to be updated with new examples of ICE's. (For now it
22-
// seems safe to assume thqt the compiler will always have *some* example
22+
// seems safe to assume that the compiler will always have *some* example
2323
// program that can be used to observe an ICE.)
2424

2525
const CARGO_TOML: &'static str = r##"
@@ -76,7 +76,7 @@ where WhichTemp: WhichTempDirectory
7676
println!("Command output stderr for {}: \n```\n{}\n```", CRATE_NAME, stderr);
7777

7878
// The most basic check: does the output actually tell us about the
79-
// "reressing" commit.
79+
// "regressing" commit.
8080
let needle = format!("regression in {}", INJECTION_COMMIT);
8181
// println!("searching for {:?} in stdout: {:?} stderr: {:?}", needle, stdout, stderr);
8282
assert!(stderr.contains(&needle));

0 commit comments

Comments
 (0)