Skip to content

Commit a4a8bd1

Browse files
committed
Auto merge of #12021 - ehuss:update-windows-sys, r=weihanglo
Update windows-sys This updates the windows-sys dependency from 0.45 to 0.48. This shouldn't add or remove any duplicate dependencies (since there are other dependencies still using 0.45 and 0.42). The intent is to move it along the direction towards unifying in the future (though it seems like a moving target that will be difficult to ever hit). This also bumps the home crate version. I think it should be OK to make the migration from winapi to windows-sys a patch version, though there seems to be some issues with the way windows-sys works that could introduce some build-time problems in some situations (such as those encountered in rust-lang/rust#108665 and rust-lang/rust#106610). However, I don't expect too much of an issue.
2 parents c5bee5d + ac25009 commit a4a8bd1

File tree

9 files changed

+24
-21
lines changed

9 files changed

+24
-21
lines changed

Cargo.lock

+11-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ openssl = { version = "0.10.50", optional = true }
9595
fwdansi = "1.1.0"
9696

9797
[target.'cfg(windows)'.dependencies.windows-sys]
98-
version = "0.45"
98+
version = "0.48"
9999
features = [
100100
"Win32_Foundation",
101101
"Win32_Storage_FileSystem",

crates/cargo-test-support/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ toml = "0.7.0"
2929
url = "2.2.2"
3030

3131
[target.'cfg(windows)'.dependencies]
32-
windows-sys = { version = "0.45.0", features = ["Win32_Storage_FileSystem"] }
32+
windows-sys = { version = "0.48.0", features = ["Win32_Storage_FileSystem"] }

crates/cargo-util/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ core-foundation = { version = "0.9.0", features = ["mac_os_10_7_support"] }
2525

2626
[target.'cfg(windows)'.dependencies]
2727
miow = "0.5.0"
28-
windows-sys = { version = "0.45.0", features = ["Win32_Storage_FileSystem", "Win32_Foundation", "Win32_System_Console"] }
28+
windows-sys = { version = "0.48.0", features = ["Win32_Storage_FileSystem", "Win32_Foundation", "Win32_System_Console"] }

crates/home/CHANGELOG.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
<!-- ## [Unreleased] -->
7+
## Unreleased
8+
- The `home` crate has migrated to the <https://github.com/rust-lang/cargo/> repository.
9+
[#11359](https://github.com/rust-lang/cargo/pull/11359)
10+
- Replaced the winapi dependency with windows-sys.
11+
[#11656](https://github.com/rust-lang/cargo/pull/11656)
812

913
## [0.5.4] - 2022-10-10
1014
- Add `_with_env` variants of functions to support in-process threaded tests for
@@ -38,7 +42,6 @@ Use Rust 1.36.0 as minimum Rust version.
3842
### Removed
3943
- Remove support for `multirust` folder used in old version of `rustup`.
4044

41-
[Unreleased]: https://github.com/brson/home/compare/v0.5.4...HEAD
4245
[0.5.4]: https://github.com/brson/home/compare/v0.5.3...v0.5.4
4346
[0.5.3]: https://github.com/brson/home/compare/v0.5.2...v0.5.3
4447
[0.5.2]: https://github.com/brson/home/compare/v0.5.1...v0.5.2

crates/home/Cargo.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "home"
3-
version = "0.5.4" # also update `html_root_url` in `src/lib.rs`
3+
version = "0.5.5" # also update `html_root_url` in `src/lib.rs`
44
authors = ["Brian Anderson <[email protected]>"]
55
documentation = "https://docs.rs/home"
66
edition = "2018"
@@ -17,4 +17,4 @@ repository = "https://github.com/rust-lang/cargo"
1717
description = "Shared definitions of home directories."
1818

1919
[target.'cfg(windows)'.dependencies]
20-
windows-sys = { version = "0.45.0", features = ["Win32_Foundation", "Win32_UI_Shell"] }
20+
windows-sys = { version = "0.48.0", features = ["Win32_Foundation", "Win32_UI_Shell"] }

crates/home/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
//!
2626
//! [discussion]: https://github.com/rust-lang/rust/pull/46799#issuecomment-361156935
2727
28-
#![doc(html_root_url = "https://docs.rs/home/0.5.4")]
28+
#![doc(html_root_url = "https://docs.rs/home/0.5.5")]
2929
#![deny(rust_2018_idioms)]
3030

3131
pub mod env;

credential/cargo-credential-wincred/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ description = "A Cargo credential process that stores tokens with Windows Creden
88

99
[dependencies]
1010
cargo-credential = { version = "0.2.0", path = "../cargo-credential" }
11-
windows-sys = { version = "0.45", features = ["Win32_Foundation", "Win32_Security_Credentials"] }
11+
windows-sys = { version = "0.48", features = ["Win32_Foundation", "Win32_Security_Credentials"] }

src/cargo/core/shell.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -563,13 +563,13 @@ mod imp {
563563
use windows_sys::core::PCSTR;
564564
use windows_sys::Win32::Foundation::CloseHandle;
565565
use windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE;
566+
use windows_sys::Win32::Foundation::{GENERIC_READ, GENERIC_WRITE};
566567
use windows_sys::Win32::Storage::FileSystem::{
567568
CreateFileA, FILE_SHARE_READ, FILE_SHARE_WRITE, OPEN_EXISTING,
568569
};
569570
use windows_sys::Win32::System::Console::{
570571
GetConsoleScreenBufferInfo, GetStdHandle, CONSOLE_SCREEN_BUFFER_INFO, STD_ERROR_HANDLE,
571572
};
572-
use windows_sys::Win32::System::SystemServices::{GENERIC_READ, GENERIC_WRITE};
573573

574574
pub(super) use super::{default_err_erase_line as err_erase_line, TtyWidth};
575575

0 commit comments

Comments
 (0)