Skip to content

Commit d662521

Browse files
committed
add clippy to CI
1 parent ddf6e3c commit d662521

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/workflows/main.yml

+16-2
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,20 @@ jobs:
109109
- uses: actions/checkout@v1
110110
with:
111111
submodules: true
112-
- name: Install Rust
113-
run: rustup update stable && rustup default stable && rustup component add rustfmt
112+
- name: Install stable `rustfmt`
113+
run: rustup set profile minimal && rustup default stable && rustup component add rustfmt
114114
- run: cargo fmt -- --check
115+
116+
clippy:
117+
name: Clippy
118+
runs-on: ubuntu-latest
119+
steps:
120+
- uses: actions/checkout@v1
121+
with:
122+
submodules: true
123+
# Unlike rustfmt, stable clippy does not work on code with nightly features.
124+
# This acquires the most recent nightly with a clippy component.
125+
- name: Install nightly `clippy`
126+
run: |
127+
rustup set profile minimal && rustup default "nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/clippy)" && rustup component add clippy
128+
- run: cargo clippy -- -D clippy::all

src/int/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,8 @@ macro_rules! int_impl {
210210
self
211211
}
212212

213+
// It makes writing macros easier if this is implemented for both signed and unsigned
214+
#[allow(clippy::wrong_self_convention)]
213215
fn from_unsigned(me: $uty) -> Self {
214216
me
215217
}

0 commit comments

Comments
 (0)