Skip to content

Commit 34981d9

Browse files
committed
update some comments
1 parent d6ae29d commit 34981d9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/web/crate_details.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -504,9 +504,9 @@ pub(crate) async fn get_all_releases(
504504
.into_canonical_req_version_or_else(|_| AxumNope::VersionNotFound)?;
505505

506506
if matched_release.build_status() != BuildStatus::Success {
507-
// this handler should only be used for successful builds, so then we have all rows in the
507+
// This handler should only be used for successful builds, so then we have all rows in the
508508
// `releases` table filled with data.
509-
// If we at some point need this view for in-progress releases or failed releases, we need
509+
// If we need this view at some point for in-progress releases or failed releases, we need
510510
// to handle empty doc targets.
511511
return Err(AxumNope::CrateNotFound);
512512
}
@@ -640,8 +640,8 @@ pub(crate) async fn get_all_platforms_inner(
640640
|| krate.default_target.is_none()
641641
|| matched_release.target_name().is_none()
642642
{
643-
// FIXME: is this really OK? just return an empty platform list in case of
644-
// an early failure?
643+
// when the build wasn't finished, we don't have any target platforms
644+
// we could read from.
645645
return Ok(PlatformList {
646646
metadata: ShortMetadata {
647647
name: params.name,

0 commit comments

Comments
 (0)