Fix footer display following last rustdoc changes on the sidebar

Author: GuillaumeGomez

build.rs

@@ -78,6 +78,7 @@ fn compile_sass() -> Result<(), Box<dyn Error>> {
     // Compile rustdoc.scss -> rustdoc.css
     compile_sass_file("rustdoc", "rustdoc", &[])?;
     compile_sass_file("rustdoc-2021-12-05", "rustdoc-2021-12-05", &[])?;
+    compile_sass_file("rustdoc-2021-12-14", "rustdoc-2021-12-14", &[])?;
 
     // Compile vendored.scss -> vendored.css
     compile_sass_file(

src/utils/rustc_version.rs

@@ -47,6 +47,10 @@ pub fn get_correct_docsrs_style_file(version: &str) -> Result<String> {
     if Utc.ymd(2021, 12, 5) < date {
         // If this is the new rustdoc layout, we need the newer docs.rs CSS file.
         Ok("rustdoc-2021-12-05.css".to_owned())
+    }
+    // This is the date where https://github.com/rust-lang/rust/pull/92692 was merged.
+    else if Utc.ymd(2021, 12, 14) < date {
+        Ok("rustdoc-2021-12-14.css".to_owned())
     } else {
         // By default, we return the old docs.rs CSS file.
         Ok("rustdoc.css".to_owned())
@@ -72,8 +76,12 @@ fn test_get_correct_docsrs_style_file() {
         "rustdoc.css"
     );
     assert_eq!(
-        get_correct_docsrs_style_file("docsrs 0.2.0 (ba9ae23 2022-05-26)").unwrap(),
+        get_correct_docsrs_style_file("docsrs 0.2.0 (ba9ae23 2021-12-06)").unwrap(),
         "rustdoc-2021-12-05.css"
     );
+    assert_eq!(
+        get_correct_docsrs_style_file("docsrs 0.2.0 (ba9ae23 2021-12-16)").unwrap(),
+        "rustdoc-2021-12-14.css"
+    );
     assert!(get_correct_docsrs_style_file("docsrs 0.2.0").is_err(),);
 }

src/web/statics.rs

@@ -16,6 +16,8 @@ const STYLE_CSS: &str = include_str!(concat!(env!("OUT_DIR"), "/style.css"));
 const RUSTDOC_CSS: &str = include_str!(concat!(env!("OUT_DIR"), "/rustdoc.css"));
 const RUSTDOC_2021_12_05_CSS: &str =
     include_str!(concat!(env!("OUT_DIR"), "/rustdoc-2021-12-05.css"));
+const RUSTDOC_2021_12_14_CSS: &str =
+    include_str!(concat!(env!("OUT_DIR"), "/rustdoc-2021-12-14.css"));
 const STATIC_SEARCH_PATHS: &[&str] = &["static", "vendor"];
 
 pub(crate) fn static_handler(req: &mut Request) -> IronResult<Response> {
@@ -31,6 +33,10 @@ pub(crate) fn static_handler(req: &mut Request) -> IronResult<Response> {
             RUSTDOC_2021_12_05_CSS,
             ContentType("text/css".parse().unwrap()),
         ),
+        "rustdoc-2021-12-14.css" => serve_resource(
+            RUSTDOC_2021_12_14_CSS,
+            ContentType("text/css".parse().unwrap()),
+        ),
         file => serve_file(file)?,
     })
 }

templates/style/rustdoc-2021-12-14.scss

@@ -0,0 +1,40 @@
+// FIXME: Use modules
+@import "rustdoc-common";
+
+// This file is needed to overload the previous docs.rs style. It is added into crates generated
+// using rustdoc after https://github.com/rust-lang/rust/pull/92692 has been merged.
+
+#rustdoc_body_wrapper {
+    padding: 0;
+
+    .sidebar {
+        margin-top: 0;
+        top: $top-navbar-height;
+        height: calc(100vh - $top-navbar-height);
+        /* Since we use `overflow-wrap: anywhere;`, we never have the need for a X scrollbar... */
+        overflow-x: hidden;
+
+        .sidebar-menu {
+            top: $top-navbar-height;
+            margin-bottom: $footer-height;
+        }
+    }
+
+    main {
+        padding-bottom: 50px;
+    }
+}
+
+div.container-rustdoc {
+    > .docs-rs-footer {
+        bottom: 0;
+        right: 0;
+        left: 0;
+    }
+}
+
+div.rustdoc {
+    #sidebar-toggle {
+        top: 0;
+    }
+}