Skip to content

Commit fac3ea5

Browse files
GuillaumeGomezjyn514
authored andcommitted
Make source files sidebar scrolling independant
1 parent 6703394 commit fac3ea5

File tree

2 files changed

+36
-2
lines changed

2 files changed

+36
-2
lines changed

templates/crate/source.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
{%- block body -%}
2525
<div class="container package-page-container small-bottom-pad">
2626
<div class="pure-g">
27-
<div id="side-menu" class="pure-u-1 {% if file_content %}pure-u-sm-7-24 pure-u-md-5-24{% endif %}">
27+
<div id="side-menu" class="pure-u-1 {% if file_content %}pure-u-sm-7-24 pure-u-md-5-24 source-view{% endif %}">
2828
<div class="pure-menu package-menu">
2929
<ul class="pure-menu-list">
3030
{# If we are displaying a file, we also add a button to hide the file sidebar #}

templates/style/base.scss

+35-1
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,8 @@ div.package-sheet-container {
433433
}
434434
}
435435

436+
$sidebar-side-padding: 10px;
437+
436438
div.package-page-container {
437439
padding-bottom: 50px;
438440

@@ -441,7 +443,7 @@ div.package-page-container {
441443
}
442444

443445
div.package-menu {
444-
padding: 0 10px;
446+
padding: 0 $sidebar-side-padding;
445447

446448
li.pure-menu-heading {
447449
font-size: 1.3em;
@@ -816,6 +818,32 @@ ul.pure-menu-list {
816818
}
817819
}
818820

821+
#side-menu.source-view {
822+
position: relative;
823+
824+
.package-menu {
825+
position: -webkit-sticky;
826+
position: sticky;
827+
top: $top-navbar-height;
828+
overflow: auto;
829+
max-height: calc(100vh - #{$top-navbar-height});
830+
height: calc(100% - #{$top-navbar-height});
831+
832+
.pure-menu-list {
833+
position: absolute;
834+
top: 0;
835+
max-height: 100vh;
836+
height: 100%;
837+
width: calc(100% - #{$sidebar-side-padding} * 2);
838+
padding-top: 5px;
839+
840+
.pure-menu-item {
841+
height: initial;
842+
}
843+
}
844+
}
845+
}
846+
819847
#side-menu.collapsed {
820848
max-width: 46px;
821849

@@ -838,6 +866,12 @@ ul.pure-menu-list {
838866
#source-code {
839867
pre {
840868
margin-top: 0;
869+
margin-bottom: 0;
870+
height: 100%;
871+
872+
code {
873+
height: 100%;
874+
}
841875
}
842876

843877
&.expanded {

0 commit comments

Comments
 (0)