Skip to content

Commit ffa296e

Browse files
committed
extend comment on match_version semver match
1 parent 6514a79 commit ffa296e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/web/mod.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,7 @@ fn semver_match<'a, F: Fn(&Release) -> bool>(
241241
req: &VersionReq,
242242
filter: F,
243243
) -> Option<&'a Release> {
244+
// first try standard semver match using `VersionReq::match`, should handle most cases.
244245
if let Some(release) = releases
245246
.iter()
246247
.filter(|release| filter(release))
@@ -249,8 +250,9 @@ fn semver_match<'a, F: Fn(&Release) -> bool>(
249250
Some(release)
250251
} else if req == &VersionReq::STAR {
251252
// semver `*` does not match pre-releases.
252-
// When someone wants the latest release and we have only pre-releases
253-
// just return the latest prerelease.
253+
// So when we only have pre-releases, `VersionReq::STAR` would lead to an
254+
// empty result.
255+
// In this case we just return the latest latest prerelase instead of nothing.
254256
return releases.iter().find(|release| filter(release));
255257
} else {
256258
None

0 commit comments

Comments
 (0)