Skip to content

Commit 7b7e1cd

Browse files
tgross35tgross35
authored
Merge pull request #4236 from lvllvl/4117-part-8
Classify FIXMEs - 8
2 parents 970cbcb + 67d2ead commit 7b7e1cd

File tree

1 file changed

+37
-37
lines changed

1 file changed

+37
-37
lines changed

‎libc-test/build.rs

+37-37
Original file line numberDiff line numberDiff line change
@@ -4115,29 +4115,29 @@ fn test_linux(target: &str) {
41154115
| "CANXL_XLF"
41164116
=> true,
41174117

4118-
// FIXME: Parts of netfilter/nfnetlink*.h require more recent kernel headers:
4118+
// FIXME(linux): Parts of netfilter/nfnetlink*.h require more recent kernel headers:
41194119
| "RTNLGRP_MCTP_IFADDR" // linux v5.17+
41204120
| "RTNLGRP_TUNNEL" // linux v5.18+
41214121
| "RTNLGRP_STATS" // linux v5.18+
41224122
=> true,
41234123

4124-
// FIXME: The below is no longer const in glibc 2.34:
4124+
// FIXME(linux): The below is no longer const in glibc 2.34:
41254125
// https://github.com/bminor/glibc/commit/5d98a7dae955bafa6740c26eaba9c86060ae0344
41264126
| "PTHREAD_STACK_MIN"
41274127
| "SIGSTKSZ"
41284128
| "MINSIGSTKSZ"
41294129
if gnu => true,
41304130

4131-
// FIXME: Linux >= 5.16:
4131+
// FIXME(linux): Linux >= 5.16:
41324132
// https://github.com/torvalds/linux/commit/42df6e1d221dddc0f2acf2be37e68d553ad65f96
41334133
"NF_NETDEV_EGRESS" if sparc64 => true,
41344134
// value changed
41354135
"NF_NETDEV_NUMHOOKS" if sparc64 => true,
41364136

4137-
// FIXME: requires Linux >= v5.8
4137+
// FIXME(linux): requires Linux >= v5.8
41384138
"IF_LINK_MODE_TESTING" if sparc64 => true,
41394139

4140-
// FIXME: Requires >= 6.3 kernel headers
4140+
// FIXME(linux): Requires >= 6.3 kernel headers
41414141
"MFD_EXEC" | "MFD_NOEXEC_SEAL" if sparc64 => true,
41424142

41434143
// kernel 6.1 minimum
@@ -4146,7 +4146,7 @@ fn test_linux(target: &str) {
41464146
// kernel 6.2 minimum
41474147
"TUN_F_USO4" | "TUN_F_USO6" | "IFF_NO_CARRIER" => true,
41484148

4149-
// FIXME: Requires more recent kernel headers
4149+
// FIXME(linux): Requires more recent kernel headers
41504150
| "IFLA_PARENT_DEV_NAME" // linux v5.13+
41514151
| "IFLA_PARENT_DEV_BUS_NAME" // linux v5.13+
41524152
| "IFLA_GRO_MAX_SIZE" // linux v5.16+
@@ -4159,10 +4159,10 @@ fn test_linux(target: &str) {
41594159

41604160
// kernel 6.5 minimum
41614161
"MOVE_MOUNT_BENEATH" => true,
4162-
// FIXME: Requires linux 6.1
4162+
// FIXME(linux): Requires linux 6.1
41634163
"ALG_SET_KEY_BY_KEY_SERIAL" | "ALG_SET_DRBG_ENTROPY" => true,
41644164

4165-
// FIXME: Requires more recent kernel headers
4165+
// FIXME(linux): Requires more recent kernel headers
41664166
| "FAN_FS_ERROR" // linux v5.16+
41674167
| "FAN_RENAME" // linux v5.17+
41684168
| "FAN_REPORT_TARGET_FID" // linux v5.17+
@@ -4190,18 +4190,18 @@ fn test_linux(target: &str) {
41904190
| "FAN_EPIDFD"
41914191
if musl => true,
41924192

4193-
// FIXME: Requires linux 6.5
4193+
// FIXME(linux): Requires linux 6.5
41944194
"NFT_MSG_MAX" => true,
41954195

4196-
// FIXME: Requires >= 6.6 kernel headers.
4196+
// FIXME(linux): Requires >= 6.6 kernel headers.
41974197
"XDP_USE_SG"
41984198
| "XDP_PKT_CONTD"
41994199
=>
42004200
{
42014201
true
42024202
}
42034203

4204-
// FIXME: Requires >= 6.8 kernel headers.
4204+
// FIXME(linux): Requires >= 6.8 kernel headers.
42054205
"XDP_UMEM_TX_SW_CSUM"
42064206
| "XDP_TXMD_FLAGS_TIMESTAMP"
42074207
| "XDP_TXMD_FLAGS_CHECKSUM"
@@ -4211,20 +4211,20 @@ fn test_linux(target: &str) {
42114211
true
42124212
}
42134213

4214-
// FIXME: Requires >= 6.11 kernel headers.
4214+
// FIXME(linux): Requires >= 6.11 kernel headers.
42154215
"XDP_UMEM_TX_METADATA_LEN"
42164216
=>
42174217
{
42184218
true
42194219
}
42204220

4221-
// FIXME: Requires >= 6.6 kernel headers.
4221+
// FIXME(linux): Requires >= 6.6 kernel headers.
42224222
"SYS_fchmodat2" => true,
42234223

4224-
// FIXME: Requires >= 6.10 kernel headers.
4224+
// FIXME(linux): Requires >= 6.10 kernel headers.
42254225
"SYS_mseal" => true,
42264226

4227-
// FIXME: seems to not be available all the time (from <include/linux/sched.h>:
4227+
// FIXME(linux): seems to not be available all the time (from <include/linux/sched.h>:
42284228
"PF_VCPU"
42294229
| "PF_IDLE"
42304230
| "PF_EXITING"
@@ -4253,11 +4253,11 @@ fn test_linux(target: &str) {
42534253
| "PF_BLOCK_TS"
42544254
| "PF_SUSPEND_TASK" => true,
42554255

4256-
// FIXME: Requires >= 6.9 kernel headers.
4256+
// FIXME(linux): Requires >= 6.9 kernel headers.
42574257
"EPIOCSPARAMS"
42584258
| "EPIOCGPARAMS" => true,
42594259

4260-
// FIXME: Requires >= 6.11 kernel headers.
4260+
// FIXME(linux): Requires >= 6.11 kernel headers.
42614261
"MAP_DROPPABLE" => true,
42624262

42634263
_ => false,
@@ -4285,7 +4285,7 @@ fn test_linux(target: &str) {
42854285
// test the XSI version below.
42864286
"strerror_r" => true,
42874287

4288-
// FIXME: Our API is unsound. The Rust API allows aliasing
4288+
// FIXME(linux): Our API is unsound. The Rust API allows aliasing
42894289
// pointers, but the C API requires pointers not to alias.
42904290
// We should probably be at least using `&`/`&mut` here, see:
42914291
// https://github.com/gnzlbg/ctest/issues/68
@@ -4296,10 +4296,10 @@ fn test_linux(target: &str) {
42964296
// Needs glibc 2.35 or later.
42974297
"posix_spawn_file_actions_addtcsetpgrp_np" if gnu && sparc64 => true,
42984298

4299-
// FIXME: Deprecated since glibc 2.30. Remove fn once upstream does.
4299+
// FIXME(linux): Deprecated since glibc 2.30. Remove fn once upstream does.
43004300
"sysctl" if gnu => true,
43014301

4302-
// FIXME: It now takes c_void instead of timezone since glibc 2.31.
4302+
// FIXME(linux): It now takes c_void instead of timezone since glibc 2.31.
43034303
"gettimeofday" if gnu => true,
43044304

43054305
// These are all implemented as static inline functions in uclibc, so
@@ -4327,7 +4327,7 @@ fn test_linux(target: &str) {
43274327
// assume it's a int instead.
43284328
"getnameinfo" if uclibc => true,
43294329

4330-
// FIXME: This needs musl 1.2.2 or later.
4330+
// FIXME(musl): This needs musl 1.2.2 or later.
43314331
"gettid" if musl => true,
43324332

43334333
// Needs glibc 2.33 or later.
@@ -4363,7 +4363,7 @@ fn test_linux(target: &str) {
43634363
"posix_basename" if gnu => true,
43644364
"gnu_basename" if gnu => true,
43654365

4366-
// FIXME: function pointers changed since Ubuntu 23.10
4366+
// FIXME(linux): function pointers changed since Ubuntu 23.10
43674367
"strtol" | "strtoll" | "strtoul" | "strtoull" | "fscanf" | "scanf" | "sscanf" => true,
43684368

43694369
// Added in musl 1.2.5
@@ -4425,19 +4425,19 @@ fn test_linux(target: &str) {
44254425
field == "ssi_syscall" ||
44264426
field == "ssi_call_addr" ||
44274427
field == "ssi_arch")) ||
4428-
// FIXME: After musl 1.1.24, it have only one field `sched_priority`,
4428+
// FIXME(musl): After musl 1.1.24, it have only one field `sched_priority`,
44294429
// while other fields become reserved.
44304430
(struct_ == "sched_param" && [
44314431
"sched_ss_low_priority",
44324432
"sched_ss_repl_period",
44334433
"sched_ss_init_budget",
44344434
"sched_ss_max_repl",
44354435
].contains(&field) && musl) ||
4436-
// FIXME: After musl 1.1.24, the type becomes `int` instead of `unsigned short`.
4436+
// FIXME(musl): After musl 1.1.24, the type becomes `int` instead of `unsigned short`.
44374437
(struct_ == "ipc_perm" && field == "__seq" && aarch64_musl) ||
44384438
// glibc uses unnamed fields here and Rust doesn't support that yet
44394439
(struct_ == "timex" && field.starts_with("__unused")) ||
4440-
// FIXME: It now takes mode_t since glibc 2.31 on some targets.
4440+
// FIXME(linux): It now takes mode_t since glibc 2.31 on some targets.
44414441
(struct_ == "ipc_perm" && field == "mode"
44424442
&& ((x86_64 || i686 || arm || riscv64) && gnu || x86_64_gnux32)
44434443
) ||
@@ -4486,9 +4486,9 @@ fn test_linux(target: &str) {
44864486
});
44874487

44884488
cfg.skip_roundtrip(move |s| match s {
4489-
// FIXME:
4489+
// FIXME(1.0):
44904490
"mcontext_t" if s390x => true,
4491-
// FIXME: This is actually a union.
4491+
// FIXME(union): This is actually a union.
44924492
"fpreg_t" if s390x => true,
44934493

44944494
// The test doesn't work on some env:
@@ -4522,7 +4522,7 @@ fn test_linux(target: &str) {
45224522
"fanotify_event_info_fid" => true,
45234523
"cmsghdr" => true,
45244524

4525-
// FIXME: the call ABI of max_align_t is incorrect on these platforms:
4525+
// FIXME(linux): the call ABI of max_align_t is incorrect on these platforms:
45264526
"max_align_t" if i686 || ppc64 => true,
45274527

45284528
_ => false,
@@ -4853,13 +4853,13 @@ fn test_haiku(target: &str) {
48534853
return true;
48544854
}
48554855
match ty {
4856-
// FIXME: actually a union
4856+
// FIXME(union): actually a union
48574857
"sigval" => true,
4858-
// FIXME: locale_t does not exist on Haiku
4858+
// FIXME(haiku): locale_t does not exist on Haiku
48594859
"locale_t" => true,
4860-
// FIXME: rusage has a different layout on Haiku
4860+
// FIXME(haiku): rusage has a different layout on Haiku
48614861
"rusage" => true,
4862-
// FIXME?: complains that rust aligns on 4 byte boundary, but
4862+
// FIXME(haiku): complains that rust aligns on 4 byte boundary, but
48634863
// Haiku does not align it at all.
48644864
"in6_addr" => true,
48654865
// The d_name attribute is an array of 1 on Haiku, with the
@@ -4884,7 +4884,7 @@ fn test_haiku(target: &str) {
48844884

48854885
cfg.skip_type(move |ty| {
48864886
match ty {
4887-
// FIXME: locale_t does not exist on Haiku
4887+
// FIXME(haiku): locale_t does not exist on Haiku
48884888
"locale_t" => true,
48894889
// These cause errors, to be reviewed in the future
48904890
"sighandler_t" => true,
@@ -4899,7 +4899,7 @@ fn test_haiku(target: &str) {
48994899
cfg.skip_fn(move |name| {
49004900
// skip those that are manually verified
49014901
match name {
4902-
// FIXME: does not exist on haiku
4902+
// FIXME(haiku): does not exist on haiku
49034903
"open_wmemstream" => true,
49044904
"mlockall" | "munlockall" => true,
49054905
"tcgetsid" => true,
@@ -4923,7 +4923,7 @@ fn test_haiku(target: &str) {
49234923

49244924
cfg.skip_const(move |name| {
49254925
match name {
4926-
// FIXME: these constants do not exist on Haiku
4926+
// FIXME(haiku): these constants do not exist on Haiku
49274927
"DT_UNKNOWN" | "DT_FIFO" | "DT_CHR" | "DT_DIR" | "DT_BLK" | "DT_REG" | "DT_LNK"
49284928
| "DT_SOCK" => true,
49294929
"USRQUOTA" | "GRPQUOTA" => true,
@@ -4949,7 +4949,7 @@ fn test_haiku(target: &str) {
49494949

49504950
cfg.skip_field(move |struct_, field| {
49514951
match (struct_, field) {
4952-
// FIXME: the stat struct actually has timespec members, whereas
4952+
// FIXME(time): the stat struct actually has timespec members, whereas
49534953
// the current representation has these unpacked.
49544954
("stat", "st_atime") => true,
49554955
("stat", "st_atime_nsec") => true,
@@ -4979,7 +4979,7 @@ fn test_haiku(target: &str) {
49794979
});
49804980

49814981
cfg.skip_roundtrip(move |s| match s {
4982-
// FIXME: for some reason the roundtrip check fails for cpu_info
4982+
// FIXME(1.0): for some reason the roundtrip check fails for cpu_info
49834983
"cpu_info" => true,
49844984
_ => false,
49854985
});

0 commit comments

Comments
 (0)