-
Notifications
You must be signed in to change notification settings - Fork 413
Open
Labels
A-filesArea: related to files, paths, sockets, file descriptors, or handlesArea: related to files, paths, sockets, file descriptors, or handlesA-shimsArea: This affects the external function shimsArea: This affects the external function shimsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementE-good-first-issueA good way to start contributing, mentoring is availableA good way to start contributing, mentoring is available
Description
We currently support readdir64 on Linux but readdir only on other Unixes where we need it for the standard library. We should support "readdir" everywhere ("readdir64" is Linux-specific, so that remains only there).
This is similar to #4684 so the PR will likely look a lot like #4714:
- add a new case in
unix/foreign_item.rsand remove the now-redundant cases in the other files - add a test directly invoking
readdirto ensure it actually works
Metadata
Metadata
Assignees
Labels
A-filesArea: related to files, paths, sockets, file descriptors, or handlesArea: related to files, paths, sockets, file descriptors, or handlesA-shimsArea: This affects the external function shimsArea: This affects the external function shimsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementE-good-first-issueA good way to start contributing, mentoring is availableA good way to start contributing, mentoring is available