-
Notifications
You must be signed in to change notification settings - Fork 414
Rustup #4730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rustup #4730
+123
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for derive helper compat collisions Resolves rust-lang/reference#2055 (comment) r? `@petrochenkov`
v0 mangling for std on nightly Following rust-lang/rust#89917 and rust-lang/compiler-team#938, it doesn't make sense that `std` for these channels would have legacy mangling while the user's code would use `v0`. r? `@Kobzol`
…mann More encoder minimizations follow-up to rust-lang/rust#149054
Add `Box::clone_from_ref` and similar under `feature(clone_from_ref)` Tracking issue: rust-lang/rust#149075 Accepted ACP: rust-lang/libs-team#483 This PR implements `clone_from_ref` (and `try_*` and `_*in` variants), to get a `Box<T>`, `Arc<T>`, or `Rc<T>` by cloning from a `&T` where `T: CloneToUninit`. The "Implement..." commits replace some ad-hoc conversions with `clone_from_ref` variants, which can be split out to a separate PR if desired. This PR will conflict with rust-lang/rust#148769 due to usage of `Layout::dangling` (which that PR is renaming to `dangling_ptr`), so they should not be rolled up together, and the one which merges later will need to be amended.
…manieu Stabilize `unchecked_neg` and `unchecked_shifts` Features: `unchecked_neg`, `unchecked_shifts` Tracking issue: rust-lang/rust#85122 r? `@Amanieu`
rustc_borrowck: Don't suggest changing closure param type not under user control This changes output of a handful of tests more than the one added in the first commit, but as far as I can tell, all removed suggestions were invalid. Closes rust-lang/rust#128381 which is **D-invalid-suggestion** with two 👍-votes.
Use cg_llvm's target_config in miri Fixes rust-lang/rust#149314 r? `@RalfJung`
Run `eval_config_entry` on all branches so we always emit lints Fixes rust-lang/rust#149090 Ideally I'd have liked to fix this issue using rust-lang/rust#149215, and this is still the long term plan, but this is slightly more annoying to implement than I'd have liked to, and this is also a nice and easy solution to the problem. r? `@tgross35`
…ns-liveness, r=Kivooeo add regression test for guard patterns liveness ICE closes rust-lang/rust#146445
Rollup of 5 pull requests Successful merges: - rust-lang/rust#149087 (Stabilize `unchecked_neg` and `unchecked_shifts`) - rust-lang/rust#149107 (rustc_borrowck: Don't suggest changing closure param type not under user control) - rust-lang/rust#149323 (Use cg_llvm's target_config in miri) - rust-lang/rust#149380 (Run `eval_config_entry` on all branches so we always emit lints) - rust-lang/rust#149394 (add regression test for guard patterns liveness ICE) r? `@ghost` `@rustbot` modify labels: rollup
This updates the rust-version file to 88bd39beb342e2ae7ded1eb7d58697416686d679.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 88bd39beb342e2ae7ded1eb7d58697416686d679 Filtered ref: 7c1fca9 Upstream diff: rust-lang/rust@c871d09...88bd39b This merge was created using https://github.com/rust-lang/josh-sync.
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test for another case of rust-lang/rust#149314.