Skip to content

Commit 89ee687

Browse files
committed
Update wording, and mentions of performance
1 parent 0531c8c commit 89ee687

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

text/0000-generic-assert.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# Summary
77
[summary]: #summary
88

9-
Make the `assert!` macro generic to all expressions, and extend the readability of debug dumps.
9+
Make the `assert!` macro recognize more expressions (utilizing the power of procedural macros), and extend the readability of debug dumps.
1010

1111
# Motivation
1212
[motivation]: #motivation
@@ -118,7 +118,7 @@ With expansion: (a) == (b)'
118118
[drawbacks]: #drawbacks
119119

120120
- This will generate a wave of deprecation warnings, which will be some cost for users to migrate. However, this doesn't mean that this is backward-incompatible, as long as the deprecated macros aren't removed.
121-
- This has a potential performance degradation on complex expressions, due to creating more temporaries on stack (or register).
121+
- This has a potential performance degradation on complex expressions, due to creating more temporaries on stack (or register). However, if this had clear impacts confirmed through benchmarks, we should use some kind of alternative implementation for release builds.
122122

123123
# Alternatives
124124
[alternatives]: #alternatives

0 commit comments

Comments
 (0)