Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Disable content-assist in comments #882

Open
mickaelistria opened this issue May 28, 2018 · 6 comments
Open

Disable content-assist in comments #882

mickaelistria opened this issue May 28, 2018 · 6 comments
Labels
racer an issue caused by or could be solved by Racer

Comments

@mickaelistria
Copy link

See eclipse-corrosion/corrosion#79
It seems like RLS completes inside comments as it's not really desired by typical usage.

@alexheretic
Copy link
Member

alexheretic commented Jun 2, 2018

This seems reasonable. However, I wonder if there is a case for completion in comments?

In any case it is feasible to implement this. Completion is handled by a request, the implementation of which can be found in src/actions/requests.rs

// requests.rs:294
impl RequestAction for Completion {
...

Write a little logic to tell if the position is commented => simply return empty completion suggestions here.

Also a good one to cover with a test case.

@nrc nrc added the racer an issue caused by or could be solved by Racer label Jun 4, 2018
@nrc
Copy link
Member

nrc commented Jun 4, 2018

This seems like something which would be better handled by Racer - @kngwyu do you think that is possible?

@kngwyu
Copy link
Contributor

kngwyu commented Jun 4, 2018

@nrc
I think we can.
In current implementation, racer masks all comments before trying to complete. So when the cursor is in comments, racer tries to find completion candidates to empty context...

@pravic
Copy link

pravic commented Aug 28, 2018

Same here. While suggestions in comments are useful in general (e.g. completion of type names for documentation), it is really unhelpful when it triggers after typing a dot.

Also it triggers in the middle of nowhere (e.g. in the empty file or after ;, which is nonsense) .

@alercah
Copy link

alercah commented Jan 17, 2019

+1

@pravic
Copy link

pravic commented Jan 17, 2019

Any news on that? It really slows down typing comments (and thus documentation) because of popping suggestions.

Perhaps, some instructions to point where to fix?

bors added a commit that referenced this issue Feb 5, 2019
…r=Xanewok

Bump tokio-timer from 0.2.9 to 0.2.10

Bumps [tokio-timer](https://github.com/tokio-rs/tokio) from 0.2.9 to 0.2.10.
<details>
<summary>Commits</summary>

- [`a69aca8`](tokio-rs/tokio@a69aca8) Bump tokio-timer v0.2.10 ([#886](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/886))
- [`13c9618`](tokio-rs/tokio@13c9618) tokio-timer: Fix multi reset DelayQueue bug ([#871](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/871))
- [`61d4aa9`](tokio-rs/tokio@61d4aa9) docs: replace `Prepends` with `Appends` ([#882](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/882))
- [`9d6d142`](tokio-rs/tokio@9d6d142) Bump tokio-sync v0.1.1 ([#881](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/881))
- [`95b0eec`](tokio-rs/tokio@95b0eec) sync: bounded channel can not have 0 size ([#879](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/879))
- [`e1a07ce`](tokio-rs/tokio@e1a07ce) threadpool: update crossbeam dependencies ([#874](https://github-redirect.dependabot.com/tokio-rs/tokio/issues/874))
- See full diff in [compare view](tokio-rs/tokio@tokio-timer-0.2.9...tokio-timer-0.2.10)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=tokio-timer&package-manager=cargo&previous-version=0.2.9&new-version=0.2.10)](https://dependabot.com/compatibility-score.html?dependency-name=tokio-timer&package-manager=cargo&previous-version=0.2.9&new-version=0.2.10)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
racer an issue caused by or could be solved by Racer
Projects
None yet
Development

No branches or pull requests

6 participants