Merge #6274

bors[bot] · feileacan · web-flow · commit 2c5bd9517e20 · 2020-10-19T15:35:32.000Z
6274: Check cargoExtraArgs for undefined before using r=matklad a=feileacan Fixes #6273 Co-authored-by: feileacan <54381366+feileacan@users.noreply.github.com>
diff --git a/editors/code/src/run.ts b/editors/code/src/run.ts
@@ -129,7 +129,9 @@ export async function createTask(runnable: ra.Runnable, config: Config): Promise
     }
 
     const args = [...runnable.args.cargoArgs]; // should be a copy!
-    args.push(...runnable.args.cargoExtraArgs); // Append user-specified cargo options.
+    if (runnable.args.cargoExtraArgs) {
+        args.push(...runnable.args.cargoExtraArgs); // Append user-specified cargo options.
+    }
     if (runnable.args.executableArgs.length > 0) {
         args.push('--', ...runnable.args.executableArgs);
     }

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,9 @@ export async function createTask(runnable: ra.Runnable, config: Config): Promise`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`const args = [...runnable.args.cargoArgs]; // should be a copy!`
`132`		`- args.push(...runnable.args.cargoExtraArgs); // Append user-specified cargo options.`
	`132`	`+ if (runnable.args.cargoExtraArgs) {`
	`133`	`+ args.push(...runnable.args.cargoExtraArgs); // Append user-specified cargo options.`
	`134`	`+ }`
`133`	`135`	`if (runnable.args.executableArgs.length > 0) {`
`134`	`136`	`args.push('--', ...runnable.args.executableArgs);`
`135`	`137`	`}`