Generalize disallowing of definition renaming

Author: alibektas

crates/ide-db/src/rename.rs

@@ -24,7 +24,7 @@ use std::fmt;
 
 use base_db::{AnchoredPathBuf, CrateOrigin, FileId, FileRange};
 use either::Either;
-use hir::{FieldSource, HasSource, InFile, ModuleSource, Semantics};
+use hir::{Crate, FieldSource, HasCrate, HasSource, InFile, ModuleSource, Semantics};
 use stdx::never;
 use syntax::{
     ast::{self, HasName},
@@ -71,20 +71,24 @@ impl Definition {
         sema: &Semantics<'_, RootDatabase>,
         new_name: &str,
     ) -> Result<SourceChange> {
+        if let Some(krate) = self.krate(sema.db) {
+            if !matches!(krate.origin(sema.db), CrateOrigin::Local { .. }) {
+                bail!("Cannot rename a non-local definition.")
+            }
+        }
+
         match *self {
             Definition::Module(module) => rename_mod(sema, module, new_name),
             Definition::BuiltinType(_) => {
                 bail!("Cannot rename builtin type")
             }
             Definition::SelfType(_) => bail!("Cannot rename `Self`"),
-            Definition::Adt(hir::Adt::Struct(strukt)) => {
-                if !matches!(
-                    strukt.module(sema.db).krate().origin(sema.db),
-                    CrateOrigin::Local { .. }
-                ) {
-                    bail!("Cannot rename a non-local struct.")
+            Definition::Macro(mac) => {
+                if mac.is_builtin_derive(sema.db) {
+                    bail!("Cannot rename builtin macro")
                 }
-                rename_reference(sema, Definition::Adt(hir::Adt::Struct(strukt)), new_name)
+
+                rename_reference(sema, Definition::Macro(mac), new_name)
             }
             def => rename_reference(sema, def, new_name),
         }

crates/ide/src/rename.rs

@@ -2489,7 +2489,7 @@ fn main() {
     }
 
     #[test]
-    fn disallow_renaming_for_non_local_struct() {
+    fn disallow_renaming_for_non_local_definition() {
         check(
             "Baz",
             r#"
@@ -2498,7 +2498,7 @@ pub struct S$0;
 //- /main.rs crate:main deps:lib new_source_root:local
 use lib::S;
 "#,
-            "error: Cannot rename a non-local struct.",
+            "error: Cannot rename a non-local definition.",
         );
     }
 }