Skip to content

Commit c10c6b4

Browse files
committed
Auto merge of #15159 - tetsuharuohzeki:enable-noImplicitOverride, r=Veykril
editor/code: Enable `noImplicitOverride` ts option This enables TypeScript's [`--noImplicitOverride`](https://www.typescriptlang.org/tsconfig#noImplicitOverride) option.
2 parents 89d7056 + 8e0efbc commit c10c6b4

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

editors/code/src/dependencies_provider.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ export class RustDependenciesProvider
108108

109109
export class Dependency extends vscode.TreeItem {
110110
constructor(
111-
public readonly label: string,
111+
public override readonly label: string,
112112
private version: string,
113113
readonly dependencyPath: string,
114-
public readonly collapsibleState: vscode.TreeItemCollapsibleState
114+
public override readonly collapsibleState: vscode.TreeItemCollapsibleState
115115
) {
116116
super(label, collapsibleState);
117117
this.resourceUri = vscode.Uri.file(dependencyPath);
@@ -127,10 +127,10 @@ export class Dependency extends vscode.TreeItem {
127127

128128
export class DependencyFile extends vscode.TreeItem {
129129
constructor(
130-
readonly label: string,
130+
override readonly label: string,
131131
readonly dependencyPath: string,
132132
readonly parent: Dependency | DependencyFile,
133-
public readonly collapsibleState: vscode.TreeItemCollapsibleState
133+
public override readonly collapsibleState: vscode.TreeItemCollapsibleState
134134
) {
135135
super(vscode.Uri.file(dependencyPath), collapsibleState);
136136
this.id = this.resourceUri!.fsPath.toLowerCase();

editors/code/tsconfig.json

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
// to update typescript version without any code change.
1414
"useUnknownInCatchVariables": false,
1515
"exactOptionalPropertyTypes": false,
16-
"noImplicitOverride": false,
1716
"noPropertyAccessFromIndexSignature": false,
1817
"noUncheckedIndexedAccess": false
1918
},

0 commit comments

Comments
 (0)