Does GreenNode actually use tagged pointers for children?

[szmarczak]

syntax.md

To more compactly store the children, we box both interior nodes and tokens, and represent Either<Arc<Node>, Arc<Token>> as a single pointer with a tag in the last bit.

However

https://github.com/rust-analyzer/rowan/blob/fe2e4a7059e1fb8961b92e9d7738844faad7d675/src/green/node.rs#L25-L53

In particular

static_assert!(mem::size_of::<GreenChild>() == mem::size_of::<usize>() * 2);

type Repr = HeaderSlice<GreenNodeHead, [GreenChild]>;

pub struct GreenNode {
    ptr: ThinArc<GreenNodeHead, GreenChild>,
}

It doesn't look like it does what the docs are saying.

[szmarczak]

It looks like with rust-analyzer/rowan@cfc98d3 it's no longer accurate

[szmarczak]

This guide describes the current state of syntax trees and parsing in rust-analyzer as of 2020-01-09 (link to commit).