Skip to content

Request completionItem/resolve failed #18640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Veykril opened this issue Dec 9, 2024 · 2 comments · Fixed by #18653
Closed

Request completionItem/resolve failed #18640

Veykril opened this issue Dec 9, 2024 · 2 comments · Fixed by #18653
Labels
A-completion autocompletion A-lsp LSP conformance issues and missing features C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Dec 9, 2024

This randomly occured, when it clearly shouldn't, not reproduction unfortunately

[Error - 9:18:48 AM] Request completionItem/resolve failed.
  Message: Import edit overlaps with the original completion edits, this is not LSP-compliant
  Code: -32603 
@Veykril Veykril added A-completion autocompletion A-lsp LSP conformance issues and missing features C-bug Category: bug labels Dec 9, 2024
@SomeoneToIgnore
Copy link
Contributor

This seems similar to what's been described in #18547 (comment) and another implication of the issue with the completions resolve impl.

I liked the proposed hash lookup strategy, should we try to implement that, instead of the caching approach?

@Veykril
Copy link
Member Author

Veykril commented Dec 9, 2024

Yes let's do that, the server is stateless wrt to requests so the caching would be quite annoying to implement I think (and we probably don't want to do that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion A-lsp LSP conformance issues and missing features C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants