Skip to content

"rust-intrinsic" ABI and #[rustc_intrinsic_must_be_overridden] support has been removed from the compiler #19539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skgland opened this issue Apr 7, 2025 · 2 comments
Labels
A-msrv Change that requires bumping project support MSRV S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.

Comments

@Skgland
Copy link
Contributor

Skgland commented Apr 7, 2025

It came up in rust-lang/rust#132735 that support for #[rustc_intrinsic_must_be_overridden] has been removed from rustc but is still present in rust-analyzer.
It was suggested rust-lang/rust#132735 (comment) to open an issue here.

Relevant sections of code are

"rust-intrinsic" support had been removed a bit hastily in rust-lang/rust@51b51b5 which has been reverted in rust-lang/rust#139496

@Veykril
Copy link
Member

Veykril commented Apr 7, 2025

Noting down the PR that removed this will land with 1.87, so it will be a while until we drop support for this.

@Veykril Veykril added S-unactionable Issue requires feedback, design decisions or is blocked on other work S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. A-msrv Change that requires bumping project support MSRV and removed S-unactionable Issue requires feedback, design decisions or is blocked on other work labels Apr 7, 2025
@Veykril
Copy link
Member

Veykril commented Apr 7, 2025

Once we do remove this, we can remove the rust-intrinsic support with it as well (which needs a 1.86 bump), cc rust-lang/rust#139455

@Skgland Skgland changed the title #[rustc_intrinsic_must_be_overridden] support has been removed from the compiler "rust-intrinsic" ABI and #[rustc_intrinsic_must_be_overridden] support has been removed from the compiler Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-msrv Change that requires bumping project support MSRV S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Development

No branches or pull requests

2 participants