feat: question chain api #19828
Open
feat: question chain api #19828
+423
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
nemethf
reviewed
May 27, 2025
crates/ide-db/src/source_change.rs
Outdated
| /// A list of choice groups. Each inner tuple's first string is title, second vector represents a set of options | ||
| /// from which the user can make one selection. | ||
| /// For example, `choice_options[0]` might be `["Question 1", ["Option A", "Option B"]]` and | ||
| /// `choices[1]` might be `["Question 2", ["Setting X", "Setting Y"]]`. |
There was a problem hiding this comment.
Shouldn't this be choice_options[1] instead of choices[1] ?
| @@ -202,6 +203,45 @@ impl Assists { | |||
| self.add_impl(Some(group), id, label.into(), target, &mut |it| f.take().unwrap()(it)) | |||
| } | |||
|
|
|||
| /// Give user multiple choices, user's choice will be passed to `f` as a list of indices. | |||
There was a problem hiding this comment.
I once again got a bit confused with the distinction between a multiple choice question and many consecutive questions. Surely the problem is with me, but a clarification never hurts. Thanks.
There was a problem hiding this comment.
I once again got a bit confused with the distinction between a multiple choice question and many consecutive questions. Surely the problem is with me, but a clarification never hurts. Thanks.
yes that's confusing, I should come up with a better name for them, because this api intended to provide multiple consecutive questions with multiple choices, it's a bit of confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related
#19454
overview
Added a API for asking user multiple questions and get answers, useful for quick fix that need to ask multiple question and get user choice(i.e. import all missing item, choose multiple import crates etc.)
details
Use ShowMessageRequest to send message to user, and get
MessageActionin return.The major impl is in
ask_for_choicefunction and is somewhere twisted as writing async code using callback is certainly very uncomfortable.ask_for_choicesend with a empty request id as can't determine what request id it should belong to.On the
Assistsside, developer basically provide a callback with signature ofdyn FnOnce(&mut SourceChangeBuilder, &[usize]) + Send + 'staticto handle what to do after get user choices results, so it's similar toadd_groupmethodtodo
test this with a integration test