Address vec iteration review comment

Author: jschwe

bindgen/codegen/mod.rs

@@ -59,7 +59,6 @@ use proc_macro2::{Ident, Span};
 use quote::{ToTokens, TokenStreamExt};
 
 use crate::{Entry, HashMap, HashSet};
-use itertools::izip;
 use std::borrow::Cow;
 use std::cell::Cell;
 use std::collections::VecDeque;
@@ -3286,7 +3285,7 @@ enum EnumBuilderKind {
     NewType {
         is_bitfield: bool,
         is_global: bool,
-        // if the enum is named or not.
+        /// if the enum is named or not.
         is_anonymous: bool,
     },
     Consts {
@@ -3479,25 +3478,18 @@ impl EnumBuilder {
         rust_ty: &syn::Type,
         enum_variants: &[EnumVariantInfo],
     ) -> proc_macro2::TokenStream {
-        let mut variant_idents = vec![];
-        let mut variant_values = vec![];
-        let mut variant_docs = vec![];
-        for v in enum_variants {
-            variant_idents.push(v.variant_name.clone());
-            variant_values.push(v.value.clone());
-            variant_docs.push(v.variant_doc.clone());
-        }
-
         let enum_ident = self.enum_type;
 
         // 1. Construct a list of the enum variants
         let variants = match self.kind {
             EnumBuilderKind::Rust { .. } => {
                 let mut variants = vec![];
 
-                for (variant_ident, variant_doc, variant_value) in
-                    izip!(&variant_idents, &variant_docs, &variant_values)
-                {
+                for v in enum_variants {
+                    let variant_doc = &v.variant_doc;
+                    let variant_ident = &v.variant_name;
+                    let variant_value = &v.value;
+
                     variants.push(quote! {
                         #variant_doc
                         #variant_ident = #variant_value,
@@ -3507,16 +3499,18 @@ impl EnumBuilder {
                 if variants.is_empty() {
                     variants.push(
                         quote! {__bindgen_cannot_repr_c_on_empty_enum = 0,},
-                    )
+                    );
                 }
                 variants
             }
             EnumBuilderKind::NewType { .. } => {
                 let mut variants = vec![];
 
-                for (variant_ident, variant_doc, variant_value) in
-                    izip!(&variant_idents, &variant_docs, &variant_values)
-                {
+                for v in enum_variants {
+                    let variant_doc = &v.variant_doc;
+                    let variant_ident = &v.variant_name;
+                    let variant_value = &v.value;
+
                     variants.push(quote! {
                         #variant_doc
                         pub const #variant_ident: #enum_ident = #variant_value;
@@ -3528,9 +3522,11 @@ impl EnumBuilder {
             EnumBuilderKind::ModuleConsts { .. } => {
                 let mut variants = vec![];
 
-                for (variant_ident, variant_doc, variant_value) in
-                    izip!(&variant_idents, &variant_docs, &variant_values)
-                {
+                for v in enum_variants {
+                    let variant_doc = &v.variant_doc;
+                    let variant_ident = &v.variant_name;
+                    let variant_value = &v.value;
+
                     variants.push(quote! {
                         #variant_doc
                         pub const #variant_ident: #enum_ident = #variant_value;