Disallow Copy/Clone/Eq*/Ord* for opaque types

Author: elichai

src/codegen/impl_partialeq.rs

@@ -12,13 +12,13 @@ pub fn gen_partialeq_impl(
     item: &Item,
     ty_for_impl: &proc_macro2::TokenStream,
 ) -> Option<proc_macro2::TokenStream> {
+    debug_assert!(
+        !item.is_opaque(ctx, &()),
+        "You're not supposed to call this on an opaque type"
+    );
     let mut tokens = vec![];
 
-    if item.is_opaque(ctx, &()) {
-        tokens.push(quote! {
-            &self._bindgen_opaque_blob[..] == &other._bindgen_opaque_blob[..]
-        });
-    } else if comp_info.kind() == CompKind::Union {
+    if comp_info.kind() == CompKind::Union {
         assert!(!ctx.options().rust_features().untagged_union);
         tokens.push(quote! {
             &self.bindgen_union_field[..] == &other.bindgen_union_field[..]

src/ir/item.rs

@@ -325,37 +325,37 @@ impl CanDeriveDefault for Item {
 
 impl CanDeriveCopy for Item {
     fn can_derive_copy(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_copy(ctx)
+        self.id().can_derive_copy(ctx) && !self.is_opaque(ctx, &())
     }
 }
 
 impl CanDeriveHash for Item {
     fn can_derive_hash(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_hash(ctx)
+        self.id().can_derive_hash(ctx) && !self.is_opaque(ctx, &())
     }
 }
 
 impl CanDerivePartialOrd for Item {
     fn can_derive_partialord(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_partialord(ctx)
+        self.id().can_derive_partialord(ctx) && !self.is_opaque(ctx, &())
     }
 }
 
 impl CanDerivePartialEq for Item {
     fn can_derive_partialeq(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_partialeq(ctx)
+        self.id().can_derive_partialeq(ctx) && !self.is_opaque(ctx, &())
     }
 }
 
 impl CanDeriveEq for Item {
     fn can_derive_eq(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_eq(ctx)
+        self.id().can_derive_eq(ctx) && !self.is_opaque(ctx, &())
     }
 }
 
 impl CanDeriveOrd for Item {
     fn can_derive_ord(&self, ctx: &BindgenContext) -> bool {
-        self.id().can_derive_ord(ctx)
+        self.id().can_derive_ord(ctx) && !self.is_opaque(ctx, &())
     }
 }