Attributes cleanup in tests [10/20]

Author: samueltardieu

tests/ui/let_with_type_underscore.fixed

@@ -1,7 +1,6 @@
 //@aux-build: proc_macros.rs
-#![allow(unused)]
 #![warn(clippy::let_with_type_underscore)]
-#![allow(clippy::let_unit_value, clippy::needless_late_init)]
+#![allow(clippy::needless_late_init)]
 
 extern crate proc_macros;
 

tests/ui/let_with_type_underscore.rs

@@ -1,7 +1,6 @@
 //@aux-build: proc_macros.rs
-#![allow(unused)]
 #![warn(clippy::let_with_type_underscore)]
-#![allow(clippy::let_unit_value, clippy::needless_late_init)]
+#![allow(clippy::needless_late_init)]
 
 extern crate proc_macros;
 

tests/ui/let_with_type_underscore.stderr

@@ -1,5 +1,5 @@
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:15:5
+  --> tests/ui/let_with_type_underscore.rs:14:5
    |
 LL |     let x: _ = 1;
    |     ^^^^^^^^^^^^^
@@ -13,7 +13,7 @@ LL +     let x = 1;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:17:5
+  --> tests/ui/let_with_type_underscore.rs:16:5
    |
 LL |     let _: _ = 2;
    |     ^^^^^^^^^^^^^
@@ -25,7 +25,7 @@ LL +     let _ = 2;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:19:5
+  --> tests/ui/let_with_type_underscore.rs:18:5
    |
 LL |     let x: _ = func();
    |     ^^^^^^^^^^^^^^^^^^
@@ -37,7 +37,7 @@ LL +     let x = func();
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:21:5
+  --> tests/ui/let_with_type_underscore.rs:20:5
    |
 LL |     let x: _;
    |     ^^^^^^^^^
@@ -49,7 +49,7 @@ LL +     let x;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:29:5
+  --> tests/ui/let_with_type_underscore.rs:28:5
    |
 LL |     let x : _ = 1;
    |     ^^^^^^^^^^^^^^
@@ -61,7 +61,7 @@ LL +     let x = 1;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:50:5
+  --> tests/ui/let_with_type_underscore.rs:49:5
    |
 LL |     let (a): _ = 0;
    |     ^^^^^^^^^^^^^^^
@@ -73,7 +73,7 @@ LL +     let (a) = 0;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:52:5
+  --> tests/ui/let_with_type_underscore.rs:51:5
    |
 LL |     let ((a)): _ = 0;
    |     ^^^^^^^^^^^^^^^^^
@@ -85,7 +85,7 @@ LL +     let ((a)) = 0;
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:54:5
+  --> tests/ui/let_with_type_underscore.rs:53:5
    |
 LL |     let ((a,)): _ = (0,);
    |     ^^^^^^^^^^^^^^^^^^^^^
@@ -97,7 +97,7 @@ LL +     let ((a,)) = (0,);
    |
 
 error: variable declared with type underscore
-  --> tests/ui/let_with_type_underscore.rs:57:5
+  --> tests/ui/let_with_type_underscore.rs:56:5
    |
 LL |     let (   (a   )   ):  _ = 0;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/ui/lines_filter_map_ok.fixed

@@ -1,4 +1,4 @@
-#![allow(clippy::map_identity)]
+#![expect(clippy::map_identity)]
 #![warn(clippy::lines_filter_map_ok)]
 
 use std::io::{self, BufRead, BufReader};

tests/ui/lines_filter_map_ok.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::map_identity)]
+#![expect(clippy::map_identity)]
 #![warn(clippy::lines_filter_map_ok)]
 
 use std::io::{self, BufRead, BufReader};

tests/ui/linkedlist.rs

@@ -1,6 +1,6 @@
 #![feature(associated_type_defaults)]
 #![warn(clippy::linkedlist)]
-#![allow(unused, dead_code, clippy::needless_pass_by_value)]
+#![expect(clippy::needless_pass_by_value)]
 
 extern crate alloc;
 use alloc::collections::linked_list::LinkedList;

tests/ui/literal_string_with_formatting_arg.rs

@@ -1,5 +1,5 @@
 #![warn(clippy::literal_string_with_formatting_args)]
-#![allow(clippy::unnecessary_literal_unwrap)]
+#![expect(clippy::unnecessary_literal_unwrap)]
 
 // Regression test for <https://github.com/rust-lang/rust-clippy/issues/13885>.
 // It's not supposed to emit the lint in this case (in `assert!` expansion).

tests/ui/literals.rs

@@ -1,11 +1,13 @@
 //@no-rustfix: overlapping suggestions
 // does not test any rustfixable lints
 
-#![warn(clippy::mixed_case_hex_literals)]
-#![warn(clippy::zero_prefixed_literal)]
-#![warn(clippy::unseparated_literal_suffix)]
-#![warn(clippy::separated_literal_suffix)]
-#![allow(dead_code, overflowing_literals)]
+#![warn(
+    clippy::mixed_case_hex_literals,
+    clippy::separated_literal_suffix,
+    clippy::unseparated_literal_suffix,
+    clippy::zero_prefixed_literal
+)]
+#![expect(overflowing_literals)]
 
 fn main() {
     let ok1 = 0xABCD;

tests/ui/literals.stderr

@@ -1,5 +1,5 @@
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:13:15
+  --> tests/ui/literals.rs:15:15
    |
 LL |     let ok4 = 0xab_cd_i32;
    |               ^^^^^^^^^^^ help: remove the underscore: `0xab_cdi32`
@@ -8,19 +8,19 @@ LL |     let ok4 = 0xab_cd_i32;
    = help: to override `-D warnings` add `#[allow(clippy::separated_literal_suffix)]`
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:16:15
+  --> tests/ui/literals.rs:18:15
    |
 LL |     let ok5 = 0xAB_CD_u32;
    |               ^^^^^^^^^^^ help: remove the underscore: `0xAB_CDu32`
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:19:15
+  --> tests/ui/literals.rs:21:15
    |
 LL |     let ok5 = 0xAB_CD_isize;
    |               ^^^^^^^^^^^^^ help: remove the underscore: `0xAB_CDisize`
 
 error: inconsistent casing in hexadecimal literal
-  --> tests/ui/literals.rs:22:17
+  --> tests/ui/literals.rs:24:17
    |
 LL |     let fail1 = 0xabCD;
    |                 ^^^^^^
@@ -30,49 +30,49 @@ LL |     let fail1 = 0xabCD;
    = help: to override `-D warnings` add `#[allow(clippy::mixed_case_hex_literals)]`
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:25:17
+  --> tests/ui/literals.rs:27:17
    |
 LL |     let fail2 = 0xabCD_u32;
    |                 ^^^^^^^^^^ help: remove the underscore: `0xabCDu32`
 
 error: inconsistent casing in hexadecimal literal
-  --> tests/ui/literals.rs:25:17
+  --> tests/ui/literals.rs:27:17
    |
 LL |     let fail2 = 0xabCD_u32;
    |                 ^^^^^^^^^^
    |
    = help: consider using `0xabcd_u32` or `0xABCD_u32`
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:29:17
+  --> tests/ui/literals.rs:31:17
    |
 LL |     let fail2 = 0xabCD_isize;
    |                 ^^^^^^^^^^^^ help: remove the underscore: `0xabCDisize`
 
 error: inconsistent casing in hexadecimal literal
-  --> tests/ui/literals.rs:29:17
+  --> tests/ui/literals.rs:31:17
    |
 LL |     let fail2 = 0xabCD_isize;
    |                 ^^^^^^^^^^^^
    |
    = help: consider using `0xabcd_isize` or `0xABCD_isize`
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:33:17
+  --> tests/ui/literals.rs:35:17
    |
 LL |     let fail2 = 0xab_CD_isize;
    |                 ^^^^^^^^^^^^^ help: remove the underscore: `0xab_CDisize`
 
 error: inconsistent casing in hexadecimal literal
-  --> tests/ui/literals.rs:33:17
+  --> tests/ui/literals.rs:35:17
    |
 LL |     let fail2 = 0xab_CD_isize;
    |                 ^^^^^^^^^^^^^
    |
    = help: consider using `0xab_cd_isize` or `0xAB_CD_isize`
 
 error: integer type suffix should be separated by an underscore
-  --> tests/ui/literals.rs:37:27
+  --> tests/ui/literals.rs:39:27
    |
 LL |     let fail_multi_zero = 000_123usize;
    |                           ^^^^^^^^^^^^ help: add an underscore: `000_123_usize`
@@ -81,7 +81,7 @@ LL |     let fail_multi_zero = 000_123usize;
    = help: to override `-D warnings` add `#[allow(clippy::unseparated_literal_suffix)]`
 
 error: this is a decimal constant
-  --> tests/ui/literals.rs:37:27
+  --> tests/ui/literals.rs:39:27
    |
 LL |     let fail_multi_zero = 000_123usize;
    |                           ^^^^^^^^^^^^
@@ -100,13 +100,13 @@ LL +     let fail_multi_zero = 0o123usize;
    |
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:42:16
+  --> tests/ui/literals.rs:44:16
    |
 LL |     let ok10 = 0_i64;
    |                ^^^^^ help: remove the underscore: `0i64`
 
 error: this is a decimal constant
-  --> tests/ui/literals.rs:45:17
+  --> tests/ui/literals.rs:47:17
    |
 LL |     let fail8 = 0123;
    |                 ^^^^
@@ -122,13 +122,13 @@ LL |     let fail8 = 0o123;
    |                  +
 
 error: integer type suffix should not be separated by an underscore
-  --> tests/ui/literals.rs:55:16
+  --> tests/ui/literals.rs:57:16
    |
 LL |     let ok17 = 0x123_4567_8901_usize;
    |                ^^^^^^^^^^^^^^^^^^^^^ help: remove the underscore: `0x123_4567_8901usize`
 
 error: digits grouped inconsistently by underscores
-  --> tests/ui/literals.rs:60:18
+  --> tests/ui/literals.rs:62:18
    |
 LL |     let fail19 = 12_3456_21;
    |                  ^^^^^^^^^^ help: consider: `12_345_621`
@@ -137,19 +137,19 @@ LL |     let fail19 = 12_3456_21;
    = help: to override `-D warnings` add `#[allow(clippy::inconsistent_digit_grouping)]`
 
 error: digits grouped inconsistently by underscores
-  --> tests/ui/literals.rs:63:18
+  --> tests/ui/literals.rs:65:18
    |
 LL |     let fail22 = 3__4___23;
    |                  ^^^^^^^^^ help: consider: `3_423`
 
 error: digits grouped inconsistently by underscores
-  --> tests/ui/literals.rs:66:18
+  --> tests/ui/literals.rs:68:18
    |
 LL |     let fail23 = 3__16___23;
    |                  ^^^^^^^^^^ help: consider: `31_623`
 
 error: digits of hex, binary or octal literal not in groups of equal size
-  --> tests/ui/literals.rs:69:18
+  --> tests/ui/literals.rs:71:18
    |
 LL |     let fail24 = 0xAB_ABC_AB;
    |                  ^^^^^^^^^^^ help: consider: `0x0ABA_BCAB`
@@ -158,7 +158,7 @@ LL |     let fail24 = 0xAB_ABC_AB;
    = help: to override `-D warnings` add `#[allow(clippy::unusual_byte_groupings)]`
 
 error: this is a decimal constant
-  --> tests/ui/literals.rs:79:13
+  --> tests/ui/literals.rs:81:13
    |
 LL |     let _ = 08;
    |             ^^
@@ -170,7 +170,7 @@ LL +     let _ = 8;
    |
 
 error: this is a decimal constant
-  --> tests/ui/literals.rs:82:13
+  --> tests/ui/literals.rs:84:13
    |
 LL |     let _ = 09;
    |             ^^
@@ -182,7 +182,7 @@ LL +     let _ = 9;
    |
 
 error: this is a decimal constant
-  --> tests/ui/literals.rs:85:13
+  --> tests/ui/literals.rs:87:13
    |
 LL |     let _ = 089;
    |             ^^^

tests/ui/lossy_float_literal.fixed

@@ -1,5 +1,5 @@
 #![warn(clippy::lossy_float_literal)]
-#![allow(overflowing_literals, unused)]
+#![expect(overflowing_literals)]
 #![feature(f128)]
 #![feature(f16)]