Suggest replacing manual equality assertion with assert_eq!

[ulrichstark]

What it does

Suggests replacing assert!(matches!(a, b)) and assert!(a == b); with assert_eq!(a, b) if PartialEq and Debug is implemented

Advantage

• communicates the intent more directly
• provides better debugging output if the assertion fails

Example

Suppose ...

#[derive(PartialEq, Debug)]
enum Enum {
    A,
    B,
}

let value = Enum::A;

Then the following code

assert!(matches!(value, Enum::A));
// or
assert!(value == Enum::A);

could be written as:

assert_eq!(value, Enum::A);

Also similar case possible for assert_ne!, debug_assert_eq!, debug_assert_ne!

[mi2ebi]

When dealing with eg very long strings I sometimes prefer assert! specifically so I don't have to see them

[samueltardieu]

Related: #6637