From 06d0525851199f607f42de73d93e8a7090e9268d Mon Sep 17 00:00:00 2001 From: David Wood Date: Wed, 16 Apr 2025 14:14:08 +0000 Subject: [PATCH 1/2] document reqd. approvals for target changes --- src/compiler/proposals-and-stabilization.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index 48359670..d7886b84 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -263,11 +263,25 @@ circumstance. in the description - New targets should be assigned to the compiler team co-leads to ensure that any demands on the project infrastructure are considered and checked with relevant teams +- Renaming a target or making a breaking change to a tier three target + - **Propose using:** PR + - **Approve using:** r+ + - Open an PR with the proposed rename and describe the motivation for the change and obtain a r+ + from the reviewer. +- Renaming a target or making a breaking change to a tier two or one target + - **Propose using:** MCP + - **Approve using:** FCP + - Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP. + - If approved, the change should be accompanied by a blog post announcing the change with a + notice period of at least one release before the change applies. - Demoting/removing a target - **Propose using:** MCP - **Approve using:** FCP - Write an MCP describing why the target should be demoted/removed and once discussion has concluded, an FCP can be started to approve the demotion/removal. + - If approved and affecting a tier two or one target , the change should be accompanied by a + blog post announcing the change with a notice period of at least one release before the change + applies. - Changing target baseline (e.g. minimum Darwin or Windows version bump) - **Propose using:** MCP - **Approve using:** FCP From d17ca369a7505132348c488e07deb0f55d75325d Mon Sep 17 00:00:00 2001 From: David Wood Date: Wed, 16 Apr 2025 21:48:47 +0100 Subject: [PATCH 2/2] remove extra space MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> --- src/compiler/proposals-and-stabilization.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/proposals-and-stabilization.md b/src/compiler/proposals-and-stabilization.md index d7886b84..3916677d 100644 --- a/src/compiler/proposals-and-stabilization.md +++ b/src/compiler/proposals-and-stabilization.md @@ -279,7 +279,7 @@ circumstance. - **Approve using:** FCP - Write an MCP describing why the target should be demoted/removed and once discussion has concluded, an FCP can be started to approve the demotion/removal. - - If approved and affecting a tier two or one target , the change should be accompanied by a + - If approved and affecting a tier two or one target, the change should be accompanied by a blog post announcing the change with a notice period of at least one release before the change applies. - Changing target baseline (e.g. minimum Darwin or Windows version bump)