-
Notifications
You must be signed in to change notification settings - Fork 13.3k
/
Copy pathcast.rs
571 lines (476 loc) · 13 KB
/
cast.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
//@no-rustfix
#![warn(
clippy::cast_precision_loss,
clippy::cast_possible_truncation,
clippy::cast_sign_loss,
clippy::cast_possible_wrap
)]
#![allow(
clippy::cast_abs_to_unsigned,
clippy::no_effect,
clippy::unnecessary_min_or_max,
clippy::unnecessary_operation,
clippy::unnecessary_literal_unwrap,
clippy::identity_op
)]
// FIXME(f16_f128): add tests once const casting is available for these types
fn main() {
// Test clippy::cast_precision_loss
let x0 = 1i32;
x0 as f32;
//~^ cast_precision_loss
let x1 = 1i64;
x1 as f32;
//~^ cast_precision_loss
x1 as f64;
//~^ cast_precision_loss
let x2 = 1u32;
x2 as f32;
//~^ cast_precision_loss
let x3 = 1u64;
x3 as f32;
//~^ cast_precision_loss
x3 as f64;
//~^ cast_precision_loss
// Test clippy::cast_possible_truncation
1f32 as i32;
//~^ cast_possible_truncation
1f32 as u32;
//~^ cast_possible_truncation
//~| cast_sign_loss
1f64 as f32;
//~^ cast_possible_truncation
1i32 as i8;
//~^ cast_possible_truncation
1i32 as u8;
//~^ cast_possible_truncation
1f64 as isize;
//~^ cast_possible_truncation
1f64 as usize;
//~^ cast_possible_truncation
//~| cast_sign_loss
1f32 as u32 as u16;
//~^ cast_possible_truncation
//~| cast_possible_truncation
//~| cast_sign_loss
{
let _x: i8 = 1i32 as _;
//~^ cast_possible_truncation
1f32 as i32;
//~^ cast_possible_truncation
1f64 as i32;
//~^ cast_possible_truncation
1f32 as u8;
//~^ cast_possible_truncation
//~| cast_sign_loss
}
// Test clippy::cast_possible_wrap
1u8 as i8;
//~^ cast_possible_wrap
1u16 as i16;
//~^ cast_possible_wrap
1u32 as i32;
//~^ cast_possible_wrap
1u64 as i64;
//~^ cast_possible_wrap
1usize as isize;
//~^ cast_possible_wrap
// should not wrap, usize is never 8 bits
1usize as i8;
//~^ cast_possible_truncation
// wraps on 16 bit ptr size
1usize as i16;
//~^ cast_possible_truncation
//~| cast_possible_wrap
// wraps on 32 bit ptr size
1usize as i32;
//~^ cast_possible_truncation
//~| cast_possible_wrap
// wraps on 64 bit ptr size
1usize as i64;
//~^ cast_possible_wrap
// should not wrap, isize is never 8 bits
1u8 as isize;
// wraps on 16 bit ptr size
1u16 as isize;
//~^ cast_possible_wrap
// wraps on 32 bit ptr size
1u32 as isize;
//~^ cast_possible_wrap
// wraps on 64 bit ptr size
1u64 as isize;
//~^ cast_possible_truncation
//~| cast_possible_wrap
// Test clippy::cast_sign_loss
1i32 as u32;
-1i32 as u32;
//~^ cast_sign_loss
1isize as usize;
-1isize as usize;
//~^ cast_sign_loss
0i8 as u8;
i8::MAX as u8;
i16::MAX as u16;
i32::MAX as u32;
i64::MAX as u64;
i128::MAX as u128;
(-1i8).saturating_abs() as u8;
// abs() can return a negative value in release builds
(i8::MIN).abs() as u8;
//~^ cast_sign_loss
(-1i16).saturating_abs() as u16;
(-1i32).saturating_abs() as u32;
(-1i64).abs() as u64;
//~^ cast_sign_loss
(-1isize).abs() as usize;
//~^ cast_sign_loss
(-1i8).checked_abs().unwrap() as u8;
(i8::MIN).checked_abs().unwrap() as u8;
(-1i16).checked_abs().unwrap() as u16;
(-1i32).checked_abs().unwrap() as u32;
// SAFETY: -1 is a small number which will always return Some
(unsafe { (-1i64).checked_abs().unwrap_unchecked() }) as u64;
//~^ cast_sign_loss
(-1isize).checked_abs().expect("-1 is a small number") as usize;
(-1i8).isqrt() as u8;
(i8::MIN).isqrt() as u8;
(-1i16).isqrt() as u16;
(-1i32).isqrt() as u32;
(-1i64).isqrt() as u64;
(-1isize).isqrt() as usize;
(-1i8).checked_isqrt().unwrap() as u8;
(i8::MIN).checked_isqrt().unwrap() as u8;
(-1i16).checked_isqrt().unwrap() as u16;
(-1i32).checked_isqrt().unwrap() as u32;
// SAFETY: -1 is a small number which will always return Some
(unsafe { (-1i64).checked_isqrt().unwrap_unchecked() }) as u64;
//~^ cast_sign_loss
(-1isize).checked_isqrt().expect("-1 is a small number") as usize;
(-1i8).rem_euclid(1i8) as u8;
(-1i8).wrapping_rem_euclid(1i8) as u16;
(-1i16).rem_euclid(1i16) as u16;
(-1i16).rem_euclid(1i16) as u32;
(-1i32).rem_euclid(1i32) as u32;
(-1i32).rem_euclid(1i32) as u64;
(-1i64).rem_euclid(1i64) as u64;
(-1i64).rem_euclid(1i64) as u128;
(-1isize).rem_euclid(1isize) as usize;
(1i8).rem_euclid(-1i8) as u8;
(1i8).wrapping_rem_euclid(-1i8) as u16;
(1i16).rem_euclid(-1i16) as u16;
(1i16).rem_euclid(-1i16) as u32;
(1i32).rem_euclid(-1i32) as u32;
(1i32).rem_euclid(-1i32) as u64;
(1i64).rem_euclid(-1i64) as u64;
(1i64).rem_euclid(-1i64) as u128;
(1isize).rem_euclid(-1isize) as usize;
(-1i8).checked_rem_euclid(1i8).unwrap() as u8;
(-1i8).checked_rem_euclid(1i8).unwrap() as u16;
(-1i16).checked_rem_euclid(1i16).unwrap() as u16;
(-1i16).checked_rem_euclid(1i16).unwrap() as u32;
(-1i32).checked_rem_euclid(1i32).unwrap() as u32;
(-1i32).checked_rem_euclid(1i32).unwrap() as u64;
(-1i64).checked_rem_euclid(1i64).unwrap() as u64;
(-1i64).checked_rem_euclid(1i64).unwrap() as u128;
(-1isize).checked_rem_euclid(1isize).unwrap() as usize;
(1i8).checked_rem_euclid(-1i8).unwrap() as u8;
(1i8).checked_rem_euclid(-1i8).unwrap() as u16;
(1i16).checked_rem_euclid(-1i16).unwrap() as u16;
(1i16).checked_rem_euclid(-1i16).unwrap() as u32;
(1i32).checked_rem_euclid(-1i32).unwrap() as u32;
(1i32).checked_rem_euclid(-1i32).unwrap() as u64;
(1i64).checked_rem_euclid(-1i64).unwrap() as u64;
(1i64).checked_rem_euclid(-1i64).unwrap() as u128;
(1isize).checked_rem_euclid(-1isize).unwrap() as usize;
// no lint for `cast_possible_truncation`
// with `signum` method call (see issue #5395)
let x: i64 = 5;
let _ = x.signum() as i32;
let s = x.signum();
let _ = s as i32;
// Test for signed min
// should be linted because signed
(-99999999999i64).min(1) as i8;
//~^ cast_possible_truncation
// Test for various operations that remove enough bits for the result to fit
(999999u64 & 1) as u8;
(999999u64 % 15) as u8;
(999999u64 / 0x1_0000_0000_0000) as u16;
({ 999999u64 >> 56 }) as u8;
({
let x = 999999u64;
x.min(1)
}) as u8;
999999u64.clamp(0, 255) as u8;
// should still be linted
999999u64.clamp(0, 256) as u8;
//~^ cast_possible_truncation
#[derive(Clone, Copy)]
enum E1 {
A,
B,
C,
}
impl E1 {
fn test(self) {
// Don't lint. `0..=2` fits in u8
let _ = self as u8;
}
}
#[derive(Clone, Copy)]
enum E2 {
A = 255,
B,
}
impl E2 {
fn test(self) {
let _ = self as u8;
//~^ cast_possible_truncation
let _ = Self::B as u8;
//~^ cast_enum_truncation
// Don't lint. `255..=256` fits in i16
let _ = self as i16;
// Don't lint.
let _ = Self::A as u8;
}
}
#[derive(Clone, Copy)]
enum E3 {
A = -1,
B,
C = 50,
}
impl E3 {
fn test(self) {
// Don't lint. `-1..=50` fits in i8
let _ = self as i8;
}
}
#[derive(Clone, Copy)]
enum E4 {
A = -128,
B,
}
impl E4 {
fn test(self) {
// Don't lint. `-128..=-127` fits in i8
let _ = self as i8;
}
}
#[derive(Clone, Copy)]
enum E5 {
A = -129,
B = 127,
}
impl E5 {
fn test(self) {
let _ = self as i8;
//~^ cast_possible_truncation
let _ = Self::A as i8;
//~^ cast_enum_truncation
// Don't lint. `-129..=127` fits in i16
let _ = self as i16;
// Don't lint.
let _ = Self::B as u8;
}
}
#[derive(Clone, Copy)]
#[repr(u32)]
enum E6 {
A = u16::MAX as u32,
B,
}
impl E6 {
fn test(self) {
let _ = self as i16;
//~^ cast_possible_truncation
// Don't lint. `2^16-1` fits in u16
let _ = Self::A as u16;
// Don't lint. `2^16-1..=2^16` fits in u32
let _ = self as u32;
// Don't lint.
let _ = Self::A as u16;
}
}
#[derive(Clone, Copy)]
#[repr(u64)]
enum E7 {
A = u32::MAX as u64,
B,
}
impl E7 {
fn test(self) {
let _ = self as usize;
//~^ cast_possible_truncation
// Don't lint.
let _ = Self::A as usize;
// Don't lint. `2^32-1..=2^32` fits in u64
let _ = self as u64;
}
}
#[derive(Clone, Copy)]
#[repr(i128)]
enum E8 {
A = i128::MIN,
B,
C = 0,
D = i128::MAX,
}
impl E8 {
fn test(self) {
// Don't lint. `-(2^127)..=2^127-1` fits it i128
let _ = self as i128;
}
}
#[derive(Clone, Copy)]
#[repr(u128)]
enum E9 {
A,
B = u128::MAX,
}
impl E9 {
fn test(self) {
// Don't lint.
let _ = Self::A as u8;
// Don't lint. `0..=2^128-1` fits in u128
let _ = self as u128;
}
}
#[derive(Clone, Copy)]
#[repr(usize)]
enum E10 {
A,
B = u32::MAX as usize,
}
impl E10 {
fn test(self) {
let _ = self as u16;
//~^ cast_possible_truncation
// Don't lint.
let _ = Self::B as u32;
// Don't lint.
let _ = self as u64;
}
}
}
fn avoid_subtract_overflow(q: u32) {
let c = (q >> 16) as u8;
//~^ cast_possible_truncation
c as usize;
let c = (q / 1000) as u8;
//~^ cast_possible_truncation
c as usize;
}
fn issue11426() {
(&42u8 >> 0xa9008fb6c9d81e42_0e25730562a601c8_u128) as usize;
}
fn issue11642() {
fn square(x: i16) -> u32 {
let x = x as i32;
(x * x) as u32;
//~^ cast_sign_loss
x.pow(2) as u32;
(-2_i32).saturating_pow(2) as u32
}
let _a = |x: i32| -> u32 { (x * x * x * x) as u32 };
//~^ cast_sign_loss
(2_i32).checked_pow(3).unwrap() as u32;
//~^ cast_sign_loss
(-2_i32).pow(3) as u32;
//~^ cast_sign_loss
(3_i32 % 2) as u32;
(3_i32 % -2) as u32;
(-5_i32 % 2) as u32;
//~^ cast_sign_loss
(-5_i32 % -2) as u32;
//~^ cast_sign_loss
(2_i32 >> 1) as u32;
(-2_i32 >> 1) as u32;
//~^ cast_sign_loss
let x: i32 = 10;
(x * x) as u32;
//~^ cast_sign_loss
(x * x * x) as u32;
//~^ cast_sign_loss
let y: i16 = -2;
(y * y * y * y * -2) as u16;
//~^ cast_sign_loss
(y * y * y / y * 2) as u16;
//~^ cast_sign_loss
(y * y / y * 2) as u16;
//~^ cast_sign_loss
(y / y * y * -2) as u16;
//~^ cast_sign_loss
//~| eq_op
(y + y + y + -2) as u16;
//~^ cast_sign_loss
(y + y + y + 2) as u16;
//~^ cast_sign_loss
let z: i16 = 2;
(z + -2) as u16;
//~^ cast_sign_loss
(z + z + 2) as u16;
//~^ cast_sign_loss
fn foo(a: i32, b: i32, c: i32) -> u32 {
(a * a * b * b * c * c) as u32;
//~^ cast_sign_loss
(a * b * c) as u32;
//~^ cast_sign_loss
(a * -b * c) as u32;
//~^ cast_sign_loss
(a * b * c * c) as u32;
//~^ cast_sign_loss
(a * -2) as u32;
//~^ cast_sign_loss
(a * b * c * -2) as u32;
//~^ cast_sign_loss
(a / b) as u32;
//~^ cast_sign_loss
(a / b * c) as u32;
//~^ cast_sign_loss
(a / b + b * c) as u32;
//~^ cast_sign_loss
a.saturating_pow(3) as u32;
//~^ cast_sign_loss
(a.abs() * b.pow(2) / c.abs()) as u32
//~^ cast_sign_loss
}
}
fn issue11738() {
macro_rules! m {
() => {
let _ = i32::MIN as u32; // cast_sign_loss
//
//~^^ cast_sign_loss
let _ = u32::MAX as u8; // cast_possible_truncation
//
//~^^ cast_possible_truncation
let _ = std::f64::consts::PI as f32; // cast_possible_truncation
//
//~^^ cast_possible_truncation
let _ = 0i8 as i32; // cast_lossless
};
}
m!();
}
fn issue12506() -> usize {
let bar: Result<Option<i64>, u32> = Ok(Some(10));
bar.unwrap().unwrap() as usize
//~^ cast_possible_truncation
//~| cast_sign_loss
}
fn issue12721() {
fn x() -> u64 {
u64::MAX
}
// Don't lint.
(255 & 999999u64) as u8;
// Don't lint.
let _ = ((x() & 255) & 999999) as u8;
// Don't lint.
let _ = (999999 & (x() & 255)) as u8;
(256 & 999999u64) as u8;
//~^ cast_possible_truncation
(255 % 999999u64) as u8;
//~^ cast_possible_truncation
}