Fallback removal span when involving macros

```
error: a never pattern is always unreachable
  --> $DIR/pattern-behind-macro.rs:13:21
   |
LL |         never!() => {}
   |                     ^^ this will never be executed
   |
help: remove the match arm expression
   |
LL -         never!() => {}
LL +         never!(),
   |
```

Look up the macro backtrace call sites to see if we find where the macro was used as a pattern, to properly suggest removing match arm guard and body.

Author: estebank

compiler/rustc_ast_lowering/src/expr.rs

@@ -679,6 +679,16 @@ impl<'hir> LoweringContext<'_, 'hir> {
         {
             body
         } else {
+            let removal_span = |removal_span: Span| {
+                // Seek upwards in the macro call sites to see if we find the place where
+                // `pat!()` was called so that we can get the right span to remove.
+                let Some(pat_span) = pat.span.find_ancestor_in_same_ctxt(arm.span) else {
+                    return removal_span;
+                };
+                // - pat!() => {}
+                // + pat!(),
+                pat_span.shrink_to_hi().with_hi(arm.span.hi())
+            };
             // Either `body.is_none()` or `is_never_pattern` here.
             if !is_never_pattern {
                 if self.tcx.features().never_patterns() {
@@ -689,29 +699,12 @@ impl<'hir> LoweringContext<'_, 'hir> {
             } else if let Some(body) = &arm.body {
                 self.dcx().emit_err(NeverPatternWithBody {
                     span: body.span,
-                    removal_span: if pat.span.eq_ctxt(arm.span) {
-                        // - ! => {}
-                        // + !,
-                        pat.span.shrink_to_hi().with_hi(arm.span.hi())
-                    } else {
-                        // Subtly incorrect, but close enough if macros are involved.
-                        // - ! => {}
-                        // + ! => ,
-                        body.span
-                    },
+                    removal_span: removal_span(body.span),
                 });
             } else if let Some(g) = &arm.guard {
                 self.dcx().emit_err(NeverPatternWithGuard {
                     span: g.span,
-                    removal_span: if pat.span.eq_ctxt(arm.span) {
-                        // - ! if cond,
-                        // + !,
-                        pat.span.shrink_to_hi().with_hi(arm.span.hi())
-                    } else {
-                        // We have something like `never!() if cond =>`
-                        //                      We just remove ^^^^ which isn't entirely correct.
-                        g.span
-                    },
+                    removal_span: removal_span(g.span),
                 });
             }
 

src/tools/clippy/clippy_lints/src/loops/single_element_loop.rs

@@ -71,7 +71,7 @@ pub(super) fn check<'tcx>(
     {
         let mut applicability = Applicability::MachineApplicable;
         let mut pat_snip = snippet_with_applicability(cx, pat.span, "..", &mut applicability);
-        if matches!(pat.kind, PatKind::Or(..)) {
+        if matches!(pat.kind, PatKind::Or(..)) && !pat_snip.starts_with("(") {
             pat_snip = format!("({pat_snip})").into();
         }
         let mut arg_snip = snippet_with_applicability(cx, arg_expression.span, "..", &mut applicability);

tests/ui/rfcs/rfc-0000-never_patterns/parse.stderr

@@ -76,7 +76,7 @@ LL |         never!() if true,
 help: remove the match arm guard
    |
 LL -         never!() if true,
-LL +         never!() if ,,
+LL +         never!(),
    |
 
 error: aborting due to 8 previous errors

tests/ui/rfcs/rfc-0000-never_patterns/pattern-behind-macro.rs

@@ -0,0 +1,16 @@
+#![feature(never_patterns, never_type)]
+#![allow(incomplete_features)]
+
+enum Void {}
+fn main() {}
+
+macro_rules! never {
+    () => { ! }
+}
+
+fn no_arms_or_guards(x: Void) {
+    match x {
+        never!() => {}
+        //~^ ERROR a never pattern is always unreachable
+    }
+}

tests/ui/rfcs/rfc-0000-never_patterns/pattern-behind-macro.stderr

@@ -0,0 +1,14 @@
+error: a never pattern is always unreachable
+  --> $DIR/pattern-behind-macro.rs:13:21
+   |
+LL |         never!() => {}
+   |                     ^^ this will never be executed
+   |
+help: remove the match arm expression
+   |
+LL -         never!() => {}
+LL +         never!(),
+   |
+
+error: aborting due to 1 previous error
+