save dev state

Signed-off-by: onur-ozkan <[email protected]>

Author: onur-ozkan

src/bootstrap/src/core/build_steps/lint.rs

@@ -0,0 +1,19 @@
+use crate::core::builder::Builder;
+use std::path::PathBuf;
+
+pub fn lint(build: &Builder<'_>, paths: &[PathBuf]) {
+    if build.config.dry_run() {
+        return;
+    }
+
+    let compiler = build.compiler(0, build.config.build);
+
+    for path in paths {
+        let mut clippy = build.cargo_clippy_cmd(compiler);
+        clippy.current_dir(path);
+
+        clippy.env("RUSTC_BOOTSTRAP", "1");
+        clippy.args(["--all-targets", "--all-features", "--", "--D", "warnings"]);
+        build.run(&mut clippy);
+    }
+}

src/bootstrap/src/core/build_steps/mod.rs

@@ -5,6 +5,7 @@ pub(crate) mod dist;
 pub(crate) mod doc;
 pub(crate) mod format;
 pub(crate) mod install;
+pub(crate) mod lint;
 pub(crate) mod llvm;
 pub(crate) mod run;
 pub(crate) mod setup;

src/bootstrap/src/core/build_steps/test.rs

@@ -1117,6 +1117,17 @@ HELP: to skip test's attempt to check tidiness, pass `--skip src/tools/tidy` to
                 crate::exit!(1);
             }
             crate::core::build_steps::format::format(builder, !builder.config.cmd.bless(), &[]);
+
+            // TODO: don't run this by default (check if clippy is enabled in the build configuration)
+            builder.info("lint check");
+            crate::core::build_steps::lint::lint(
+                builder,
+                &[
+                    builder.src.join("src/bootstrap"),
+                    builder.src.join("src/tools/x"),
+                    builder.src.join("src/tools/compiletest"),
+                ],
+            );
         }
 
         builder.info("tidy check");