add FIXME to EnumTagInfo

RalfJung · RalfJung · commit 10c8d2afb8b9 · 2020-06-15T19:12:14.000+02:00
diff --git a/src/librustc_codegen_llvm/debuginfo/metadata.rs b/src/librustc_codegen_llvm/debuginfo/metadata.rs
@@ -1637,6 +1637,9 @@ impl VariantMemberDescriptionFactory<'ll, 'tcx> {
     }
 }
 
+// FIXME: terminology here should be aligned with `abi::TagEncoding`.
+// `OptimizedTag` is `TagEncoding::Niche`, `RegularTag` is `TagEncoding::Direct`.
+// `NoTag` should be removed; users should use `Option<EnumTagInfo>` instead.
 #[derive(Copy, Clone)]
 enum EnumTagInfo<'ll> {
     RegularTag { tag_field: Field, tag_type_metadata: &'ll DIType },

Original file line number	Diff line number	Diff line change
`@@ -1637,6 +1637,9 @@ impl VariantMemberDescriptionFactory<'ll, 'tcx> {`
`1637`	`1637`	`}`
`1638`	`1638`	`}`
`1639`	`1639`
	`1640`	+// FIXME: terminology here should be aligned with `abi::TagEncoding`.
	`1641`	+// `OptimizedTag` is `TagEncoding::Niche`, `RegularTag` is `TagEncoding::Direct`.
	`1642`	+// `NoTag` should be removed; users should use `Option<EnumTagInfo>` instead.
`1640`	`1643`	`#[derive(Copy, Clone)]`
`1641`	`1644`	`enum EnumTagInfo<'ll> {`
`1642`	`1645`	`RegularTag { tag_field: Field, tag_type_metadata: &'ll DIType },`