Leave error reporting of method calls on inference variables to method call checks

oli-obk · oli-obk · commit 1490fae63974 · 2024-06-14T10:18:40.000Z
diff --git a/compiler/rustc_hir_typeck/src/expr.rs b/compiler/rustc_hir_typeck/src/expr.rs
@@ -1331,7 +1331,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
     ) -> Ty<'tcx> {
         let rcvr_t = self.check_expr(rcvr);
         // no need to check for bot/err -- callee does that
-        let rcvr_t = self.structurally_resolve_type(rcvr.span, rcvr_t);
+        let rcvr_t = self.try_structurally_resolve_type(rcvr.span, rcvr_t);
 
         let method = match self.lookup_method(rcvr_t, segment, segment.ident.span, expr, rcvr, args)
         {
diff --git a/tests/ui/closures/deduce-signature/obligation-with-leaking-placeholders.next.stderr b/tests/ui/closures/deduce-signature/obligation-with-leaking-placeholders.next.stderr
@@ -5,7 +5,7 @@ LL |     needs_foo(|x| {
    |                ^
 ...
 LL |         x.to_string();
-   |         - type must be known at this point
+   |           --------- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
diff --git a/tests/ui/impl-trait/hidden-type-is-opaque-2.default.stderr b/tests/ui/impl-trait/hidden-type-is-opaque-2.default.stderr
@@ -5,7 +5,7 @@ LL |     Thunk::new(|mut cont| {
    |                 ^^^^^^^^
 LL |
 LL |         cont.reify_as();
-   |         ---- type must be known at this point
+   |              -------- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -19,7 +19,7 @@ LL |     Thunk::new(|mut cont| {
    |                 ^^^^^^^^
 LL |
 LL |         cont.reify_as();
-   |         ---- type must be known at this point
+   |              -------- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
diff --git a/tests/ui/impl-trait/hidden-type-is-opaque-2.next.stderr b/tests/ui/impl-trait/hidden-type-is-opaque-2.next.stderr
@@ -5,7 +5,7 @@ LL |     Thunk::new(|mut cont| {
    |                 ^^^^^^^^
 LL |
 LL |         cont.reify_as();
-   |         ---- type must be known at this point
+   |              -------- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -19,7 +19,7 @@ LL |     Thunk::new(|mut cont| {
    |                 ^^^^^^^^
 LL |
 LL |         cont.reify_as();
-   |         ---- type must be known at this point
+   |              -------- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
diff --git a/tests/ui/impl-trait/recursive-bound-eval.next.stderr b/tests/ui/impl-trait/recursive-bound-eval.next.stderr
@@ -1,8 +1,8 @@
 error[E0282]: type annotations needed
-  --> $DIR/recursive-bound-eval.rs:19:13
+  --> $DIR/recursive-bound-eval.rs:19:28
    |
 LL |     move || recursive_fn().parse()
-   |             ^^^^^^^^^^^^^^ cannot infer type
+   |                            ^^^^^ cannot infer type
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/issues/issue-2151.stderr b/tests/ui/issues/issue-2151.stderr
@@ -4,7 +4,7 @@ error[E0282]: type annotations needed
 LL |     let x = panic!();
    |         ^
 LL |     x.clone();
-   |     - type must be known at this point
+   |       ----- type must be known at this point
    |
 help: consider giving `x` an explicit type
    |
diff --git a/tests/ui/issues/issue-7092.rs b/tests/ui/issues/issue-7092.rs
@@ -9,6 +9,7 @@ fn foo(x: Whatever) {
 //~| expected enum `Whatever`
 //~| found enum `Option<_>`
             field.access(),
+            //~^ ERROR: type annotations needed
     }
 }
 
diff --git a/tests/ui/issues/issue-7092.stderr b/tests/ui/issues/issue-7092.stderr
@@ -9,6 +9,13 @@ LL |         Some(field) =>
    = note: expected enum `Whatever`
               found enum `Option<_>`
 
-error: aborting due to 1 previous error
+error[E0282]: type annotations needed
+  --> $DIR/issue-7092.rs:11:19
+   |
+LL |             field.access(),
+   |                   ^^^^^^ cannot infer type
+
+error: aborting due to 2 previous errors
 
-For more information about this error, try `rustc --explain E0308`.
+Some errors have detailed explanations: E0282, E0308.
+For more information about an error, try `rustc --explain E0282`.
diff --git a/tests/ui/lazy-type-alias-impl-trait/branches3.stderr b/tests/ui/lazy-type-alias-impl-trait/branches3.stderr
@@ -2,7 +2,7 @@ error[E0282]: type annotations needed
   --> $DIR/branches3.rs:8:10
    |
 LL |         |s| s.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -13,7 +13,7 @@ error[E0282]: type annotations needed
   --> $DIR/branches3.rs:15:10
    |
 LL |         |s| s.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -24,7 +24,7 @@ error[E0282]: type annotations needed
   --> $DIR/branches3.rs:23:10
    |
 LL |         |s| s.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -35,7 +35,7 @@ error[E0282]: type annotations needed
   --> $DIR/branches3.rs:30:10
    |
 LL |         |s| s.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
diff --git a/tests/ui/span/issue-42234-unknown-receiver-type.full.stderr b/tests/ui/span/issue-42234-unknown-receiver-type.full.stderr
@@ -4,7 +4,7 @@ error[E0282]: type annotations needed
 LL |     let x: Option<_> = None;
    |                        ^^^^ cannot infer type of the type parameter `T` declared on the enum `Option`
 LL |     x.unwrap().method_that_could_exist_on_some_type();
-   |     ---------- type must be known at this point
+   |                ------------------------------------ type must be known at this point
    |
 help: consider specifying the generic argument
    |
@@ -16,6 +16,8 @@ error[E0282]: type annotations needed
    |
 LL |         .sum::<_>()
    |          ^^^ cannot infer type of the type parameter `S` declared on the method `sum`
+LL |         .to_string()
+   |          --------- type must be known at this point
    |
 help: consider specifying the generic argument
    |
diff --git a/tests/ui/span/issue-42234-unknown-receiver-type.generic_arg.stderr b/tests/ui/span/issue-42234-unknown-receiver-type.generic_arg.stderr
@@ -4,7 +4,7 @@ error[E0282]: type annotations needed
 LL |     let x: Option<_> = None;
    |                        ^^^^ cannot infer type of the type parameter `T` declared on the enum `Option`
 LL |     x.unwrap().method_that_could_exist_on_some_type();
-   |     ---------- type must be known at this point
+   |                ------------------------------------ type must be known at this point
    |
 help: consider specifying the generic argument
    |
@@ -16,6 +16,8 @@ error[E0282]: type annotations needed
    |
 LL |         .sum::<_>()
    |          ^^^ cannot infer type of the type parameter `S` declared on the method `sum`
+LL |         .to_string()
+   |          --------- type must be known at this point
    |
 help: consider specifying the generic argument
    |
diff --git a/tests/ui/type-alias-impl-trait/closures_in_branches.stderr b/tests/ui/type-alias-impl-trait/closures_in_branches.stderr
@@ -2,7 +2,7 @@ error[E0282]: type annotations needed
   --> $DIR/closures_in_branches.rs:7:10
    |
 LL |         |x| x.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
@@ -13,7 +13,7 @@ error[E0282]: type annotations needed
   --> $DIR/closures_in_branches.rs:21:10
    |
 LL |         |x| x.len()
-   |          ^  - type must be known at this point
+   |          ^    --- type must be known at this point
    |
 help: consider giving this closure parameter an explicit type
    |
diff --git a/tests/ui/typeck/issue-13853.rs b/tests/ui/typeck/issue-13853.rs
@@ -25,7 +25,7 @@ impl Node for Stuff {
 
 fn iterate<N: Node, G: Graph<N>>(graph: &G) {
     for node in graph.iter() { //~ ERROR no method named `iter` found
-        node.zomg();
+        node.zomg(); //~ ERROR type annotations needed
     }
 }
 
diff --git a/tests/ui/typeck/issue-13853.stderr b/tests/ui/typeck/issue-13853.stderr
@@ -17,6 +17,12 @@ error[E0599]: no method named `iter` found for reference `&G` in the current sco
 LL |     for node in graph.iter() {
    |                       ^^^^ method not found in `&G`
 
+error[E0282]: type annotations needed
+  --> $DIR/issue-13853.rs:28:14
+   |
+LL |         node.zomg();
+   |              ^^^^ cannot infer type
+
 error[E0308]: mismatched types
   --> $DIR/issue-13853.rs:37:13
    |
@@ -37,7 +43,7 @@ help: consider borrowing here
 LL |     iterate(&graph);
    |             +
 
-error: aborting due to 3 previous errors
+error: aborting due to 4 previous errors
 
-Some errors have detailed explanations: E0308, E0599.
-For more information about an error, try `rustc --explain E0308`.
+Some errors have detailed explanations: E0282, E0308, E0599.
+For more information about an error, try `rustc --explain E0282`.

Original file line number	Diff line number	Diff line change
`@@ -1331,7 +1331,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {`
`1331`	`1331`	`) -> Ty<'tcx> {`
`1332`	`1332`	`let rcvr_t = self.check_expr(rcvr);`
`1333`	`1333`	`// no need to check for bot/err -- callee does that`
`1334`		`- let rcvr_t = self.structurally_resolve_type(rcvr.span, rcvr_t);`
	`1334`	`+ let rcvr_t = self.try_structurally_resolve_type(rcvr.span, rcvr_t);`
`1335`	`1335`
`1336`	`1336`	`let method = match self.lookup_method(rcvr_t, segment, segment.ident.span, expr, rcvr, args)`
`1337`	`1337`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ LL \| needs_foo(\|x\| {`
`5`	`5`	`\| ^`
`6`	`6`	`...`
`7`	`7`	`LL \| x.to_string();`
`8`		`- \| - type must be known at this point`
	`8`	`+ \| --------- type must be known at this point`
`9`	`9`	`\|`
`10`	`10`	`help: consider giving this closure parameter an explicit type`
`11`	`11`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ LL \| Thunk::new(\|mut cont\| {`
`5`	`5`	`\| ^^^^^^^^`
`6`	`6`	`LL \|`
`7`	`7`	`LL \| cont.reify_as();`
`8`		`- \| ---- type must be known at this point`
	`8`	`+ \| -------- type must be known at this point`
`9`	`9`	`\|`
`10`	`10`	`help: consider giving this closure parameter an explicit type`
`11`	`11`	`\|`
`@@ -19,7 +19,7 @@ LL \| Thunk::new(\|mut cont\| {`
`19`	`19`	`\| ^^^^^^^^`
`20`	`20`	`LL \|`
`21`	`21`	`LL \| cont.reify_as();`
`22`		`- \| ---- type must be known at this point`
	`22`	`+ \| -------- type must be known at this point`
`23`	`23`	`\|`
`24`	`24`	`help: consider giving this closure parameter an explicit type`
`25`	`25`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`error[E0282]: type annotations needed`
`2`		`- --> $DIR/recursive-bound-eval.rs:19:13`
	`2`	`+ --> $DIR/recursive-bound-eval.rs:19:28`
`3`	`3`	`\|`
`4`	`4`	`LL \| move \|\| recursive_fn().parse()`
`5`		`- \| ^^^^^^^^^^^^^^ cannot infer type`
	`5`	`+ \| ^^^^^ cannot infer type`
`6`	`6`
`7`	`7`	`error: aborting due to 1 previous error`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ error[E0282]: type annotations needed`
`4`	`4`	`LL \| let x = panic!();`
`5`	`5`	`\| ^`
`6`	`6`	`LL \| x.clone();`
`7`		`- \| - type must be known at this point`
	`7`	`+ \| ----- type must be known at this point`
`8`	`8`	`\|`
`9`	`9`	help: consider giving `x` an explicit type
`10`	`10`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ fn foo(x: Whatever) {`
`9`	`9`	//~\| expected enum `Whatever`
`10`	`10`	//~\| found enum `Option<_>`
`11`	`11`	`field.access(),`
	`12`	`+ //~^ ERROR: type annotations needed`
`12`	`13`	`}`
`13`	`14`	`}`
`14`	`15`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ error[E0282]: type annotations needed`
`2`	`2`	`--> $DIR/branches3.rs:8:10`
`3`	`3`	`\|`
`4`	`4`	`LL \| \|s\| s.len()`
`5`		`- \| ^ - type must be known at this point`
	`5`	`+ \| ^ --- type must be known at this point`
`6`	`6`	`\|`
`7`	`7`	`help: consider giving this closure parameter an explicit type`
`8`	`8`	`\|`
`@@ -13,7 +13,7 @@ error[E0282]: type annotations needed`
`13`	`13`	`--> $DIR/branches3.rs:15:10`
`14`	`14`	`\|`
`15`	`15`	`LL \| \|s\| s.len()`
`16`		`- \| ^ - type must be known at this point`
	`16`	`+ \| ^ --- type must be known at this point`
`17`	`17`	`\|`
`18`	`18`	`help: consider giving this closure parameter an explicit type`
`19`	`19`	`\|`
`@@ -24,7 +24,7 @@ error[E0282]: type annotations needed`
`24`	`24`	`--> $DIR/branches3.rs:23:10`
`25`	`25`	`\|`
`26`	`26`	`LL \| \|s\| s.len()`
`27`		`- \| ^ - type must be known at this point`
	`27`	`+ \| ^ --- type must be known at this point`
`28`	`28`	`\|`
`29`	`29`	`help: consider giving this closure parameter an explicit type`
`30`	`30`	`\|`
`@@ -35,7 +35,7 @@ error[E0282]: type annotations needed`
`35`	`35`	`--> $DIR/branches3.rs:30:10`
`36`	`36`	`\|`
`37`	`37`	`LL \| \|s\| s.len()`
`38`		`- \| ^ - type must be known at this point`
	`38`	`+ \| ^ --- type must be known at this point`
`39`	`39`	`\|`
`40`	`40`	`help: consider giving this closure parameter an explicit type`
`41`	`41`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ error[E0282]: type annotations needed`
`4`	`4`	`LL \| let x: Option<_> = None;`
`5`	`5`	\| ^^^^ cannot infer type of the type parameter `T` declared on the enum `Option`
`6`	`6`	`LL \| x.unwrap().method_that_could_exist_on_some_type();`
`7`		`- \| ---------- type must be known at this point`
	`7`	`+ \| ------------------------------------ type must be known at this point`
`8`	`8`	`\|`
`9`	`9`	`help: consider specifying the generic argument`
`10`	`10`	`\|`
`@@ -16,6 +16,8 @@ error[E0282]: type annotations needed`
`16`	`16`	`\|`
`17`	`17`	`LL \| .sum::<_>()`
`18`	`18`	\| ^^^ cannot infer type of the type parameter `S` declared on the method `sum`
	`19`	`+LL \| .to_string()`
	`20`	`+ \| --------- type must be known at this point`
`19`	`21`	`\|`
`20`	`22`	`help: consider specifying the generic argument`
`21`	`23`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ error[E0282]: type annotations needed`
`2`	`2`	`--> $DIR/closures_in_branches.rs:7:10`
`3`	`3`	`\|`
`4`	`4`	`LL \| \|x\| x.len()`
`5`		`- \| ^ - type must be known at this point`
	`5`	`+ \| ^ --- type must be known at this point`
`6`	`6`	`\|`
`7`	`7`	`help: consider giving this closure parameter an explicit type`
`8`	`8`	`\|`
`@@ -13,7 +13,7 @@ error[E0282]: type annotations needed`
`13`	`13`	`--> $DIR/closures_in_branches.rs:21:10`
`14`	`14`	`\|`
`15`	`15`	`LL \| \|x\| x.len()`
`16`		`- \| ^ - type must be known at this point`
	`16`	`+ \| ^ --- type must be known at this point`
`17`	`17`	`\|`
`18`	`18`	`help: consider giving this closure parameter an explicit type`
`19`	`19`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ impl Node for Stuff {`
`25`	`25`
`26`	`26`	`fn iterate<N: Node, G: Graph<N>>(graph: &G) {`
`27`	`27`	for node in graph.iter() { //~ ERROR no method named `iter` found
`28`		`- node.zomg();`
	`28`	`+ node.zomg(); //~ ERROR type annotations needed`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`