Skip to content

Commit 2314727

Browse files
committed
Remove FIXME about nixOS detection
1 parent 53bf24c commit 2314727

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/bootstrap/builder.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,9 @@ impl<'a> Builder<'a> {
785785

786786
// If the user has asked binaries to be patched for Nix, then
787787
// don't check for NixOS or `/lib`, just continue to the patching.
788-
// FIXME: shouldn't this take precedence over the `uname` check above?
788+
// NOTE: this intentionally comes after the Linux check:
789+
// - patchelf only works with ELF files, so no need to run it on Mac or Windows
790+
// - On other Unix systems, there is no stable syscall interface, so Nix doesn't manage the global libc.
789791
if !self.config.patch_binaries_for_nix {
790792
// Use `/etc/os-release` instead of `/etc/NIXOS`.
791793
// The latter one does not exist on NixOS when using tmpfs as root.

0 commit comments

Comments
 (0)