fix(parse): Limit frontmatter fences to 255 dashes

Like raw string literals.

Author: epage

compiler/rustc_parse/messages.ftl

@@ -347,6 +347,8 @@ parse_frontmatter_invalid_opening_preceding_whitespace = invalid preceding white
 parse_frontmatter_length_mismatch = frontmatter close does not match the opening
     .label_opening = the opening here has {$len_opening} dashes...
     .label_close = ...while the close has {$len_close} dashes
+parse_frontmatter_too_many_dashes = too many `-` symbols: frontmatter openings may be delimited by up to 255 `-` symbols
+    .label_opening = the opening here has {$len_opening} dashes...
 parse_frontmatter_unclosed = unclosed frontmatter
     .note = frontmatter opening here was not closed
 

compiler/rustc_parse/src/errors.rs

@@ -822,6 +822,16 @@ pub(crate) struct FrontmatterLengthMismatch {
     pub len_close: usize,
 }
 
+#[derive(Diagnostic)]
+#[diag(parse_frontmatter_too_many_dashes)]
+pub(crate) struct FrontmatterTooManyDashes {
+    #[primary_span]
+    pub span: Span,
+    #[label(parse_label_opening)]
+    pub opening: Span,
+    pub len_opening: usize,
+}
+
 #[derive(Diagnostic)]
 #[diag(parse_leading_plus_not_supported)]
 pub(crate) struct LeadingPlusNotSupported {

compiler/rustc_parse/src/lexer/mod.rs

@@ -665,6 +665,13 @@ impl<'psess, 'src> Lexer<'psess, 'src> {
             });
         }
 
+        // Only up to 255 `-`s are allowed in code fences
+        if u8::try_from(len_opening).is_err() {
+            let span = self.mk_sp(frontmatter_opening_pos, self.pos);
+            let opening = self.mk_sp(frontmatter_opening_pos, frontmatter_opening_end_pos);
+            self.dcx().emit_err(errors::FrontmatterTooManyDashes { span, opening, len_opening });
+        }
+
         if !rest.trim_matches(is_horizontal_whitespace).is_empty() {
             let span = self.mk_sp(last_line_start_pos, self.pos);
             self.dcx().emit_err(errors::FrontmatterExtraCharactersAfterClose { span });

tests/ui/frontmatter/fence-too-many-dashes.rs

@@ -1,12 +1,11 @@
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
+//~^ ERROR: too many `-` symbols: frontmatter openings may be delimited by up to 255 `-` symbols
 // ignore-tidy-linelength
 [dependencies]
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 
 #![feature(frontmatter)]
 
-//@ check-pass
-
 // check that we limit fence lengths
 
 fn main() {}

tests/ui/frontmatter/fence-too-many-dashes.stderr

@@ -0,0 +1,15 @@
+error: too many `-` symbols: frontmatter openings may be delimited by up to 255 `-` symbols
+  --> $DIR/fence-too-many-dashes.rs:1:1
+   |
+LL |   ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
+   |   ^---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
+   |   |
+   |  _the opening here has 256 dashes...
+   | |
+LL | |
+LL | | [dependencies]
+LL | | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
+   | |________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________^
+
+error: aborting due to 1 previous error
+