Skip to content

Commit 307dca8

Browse files
committed
Move freshness test to bootstrap
1 parent b1544dc commit 307dca8

File tree

10 files changed

+397
-317
lines changed

10 files changed

+397
-317
lines changed

Cargo.lock

-1
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,6 @@ version = "0.1.0"
304304
dependencies = [
305305
"serde",
306306
"serde_derive",
307-
"tempfile",
308307
]
309308

310309
[[package]]

src/bootstrap/Cargo.lock

+79-4
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ dependencies = [
5656
"sha2",
5757
"sysinfo",
5858
"tar",
59+
"tempfile",
5960
"termcolor",
6061
"toml",
6162
"tracing",
@@ -233,14 +234,20 @@ dependencies = [
233234
"windows-sys 0.59.0",
234235
]
235236

237+
[[package]]
238+
name = "fastrand"
239+
version = "2.3.0"
240+
source = "registry+https://github.com/rust-lang/crates.io-index"
241+
checksum = "37909eebbb50d72f9059c3b6d82c0463f2ff062c9e95845c43a6c9c0355411be"
242+
236243
[[package]]
237244
name = "fd-lock"
238245
version = "4.0.2"
239246
source = "registry+https://github.com/rust-lang/crates.io-index"
240247
checksum = "7e5768da2206272c81ef0b5e951a41862938a6070da63bcea197899942d3b947"
241248
dependencies = [
242249
"cfg-if",
243-
"rustix",
250+
"rustix 0.38.40",
244251
"windows-sys 0.52.0",
245252
]
246253

@@ -266,6 +273,18 @@ dependencies = [
266273
"version_check",
267274
]
268275

276+
[[package]]
277+
name = "getrandom"
278+
version = "0.3.2"
279+
source = "registry+https://github.com/rust-lang/crates.io-index"
280+
checksum = "73fea8450eea4bac3940448fb7ae50d91f034f941199fcd9d909a5a07aa455f0"
281+
dependencies = [
282+
"cfg-if",
283+
"libc",
284+
"r-efi",
285+
"wasi",
286+
]
287+
269288
[[package]]
270289
name = "globset"
271290
version = "0.4.15"
@@ -355,6 +374,12 @@ version = "0.4.14"
355374
source = "registry+https://github.com/rust-lang/crates.io-index"
356375
checksum = "78b3ae25bc7c8c38cec158d1f2757ee79e9b3740fbc7ccf0e59e4b08d793fa89"
357376

377+
[[package]]
378+
name = "linux-raw-sys"
379+
version = "0.9.3"
380+
source = "registry+https://github.com/rust-lang/crates.io-index"
381+
checksum = "fe7db12097d22ec582439daf8618b8fdd1a7bef6270e9af3b1ebcd30893cf413"
382+
358383
[[package]]
359384
name = "log"
360385
version = "0.4.22"
@@ -486,6 +511,12 @@ dependencies = [
486511
"proc-macro2",
487512
]
488513

514+
[[package]]
515+
name = "r-efi"
516+
version = "5.2.0"
517+
source = "registry+https://github.com/rust-lang/crates.io-index"
518+
checksum = "74765f6d916ee2faa39bc8e68e4f3ed8949b48cccdac59983d287a7cb71ce9c5"
519+
489520
[[package]]
490521
name = "redox_syscall"
491522
version = "0.5.7"
@@ -548,10 +579,23 @@ dependencies = [
548579
"bitflags",
549580
"errno",
550581
"libc",
551-
"linux-raw-sys",
582+
"linux-raw-sys 0.4.14",
552583
"windows-sys 0.52.0",
553584
]
554585

586+
[[package]]
587+
name = "rustix"
588+
version = "1.0.2"
589+
source = "registry+https://github.com/rust-lang/crates.io-index"
590+
checksum = "f7178faa4b75a30e269c71e61c353ce2748cf3d76f0c44c393f4e60abf49b825"
591+
dependencies = [
592+
"bitflags",
593+
"errno",
594+
"libc",
595+
"linux-raw-sys 0.9.3",
596+
"windows-sys 0.59.0",
597+
]
598+
555599
[[package]]
556600
name = "ryu"
557601
version = "1.0.18"
@@ -678,6 +722,19 @@ dependencies = [
678722
"xattr",
679723
]
680724

725+
[[package]]
726+
name = "tempfile"
727+
version = "3.19.0"
728+
source = "registry+https://github.com/rust-lang/crates.io-index"
729+
checksum = "488960f40a3fd53d72c2a29a58722561dee8afdd175bd88e3db4677d7b2ba600"
730+
dependencies = [
731+
"fastrand",
732+
"getrandom",
733+
"once_cell",
734+
"rustix 1.0.2",
735+
"windows-sys 0.59.0",
736+
]
737+
681738
[[package]]
682739
name = "termcolor"
683740
version = "1.4.1"
@@ -824,6 +881,15 @@ dependencies = [
824881
"winapi-util",
825882
]
826883

884+
[[package]]
885+
name = "wasi"
886+
version = "0.14.2+wasi-0.2.4"
887+
source = "registry+https://github.com/rust-lang/crates.io-index"
888+
checksum = "9683f9a5a998d873c0d21fcbe3c083009670149a8fab228644b8bd36b2c48cb3"
889+
dependencies = [
890+
"wit-bindgen-rt",
891+
]
892+
827893
[[package]]
828894
name = "winapi"
829895
version = "0.3.9"
@@ -990,15 +1056,24 @@ version = "0.52.6"
9901056
source = "registry+https://github.com/rust-lang/crates.io-index"
9911057
checksum = "589f6da84c646204747d1270a2a5661ea66ed1cced2631d546fdfb155959f9ec"
9921058

1059+
[[package]]
1060+
name = "wit-bindgen-rt"
1061+
version = "0.39.0"
1062+
source = "registry+https://github.com/rust-lang/crates.io-index"
1063+
checksum = "6f42320e61fe2cfd34354ecb597f86f413484a798ba44a8ca1165c58d42da6c1"
1064+
dependencies = [
1065+
"bitflags",
1066+
]
1067+
9931068
[[package]]
9941069
name = "xattr"
9951070
version = "1.3.1"
9961071
source = "registry+https://github.com/rust-lang/crates.io-index"
9971072
checksum = "8da84f1a25939b27f6820d92aed108f83ff920fdf11a7b19366c27c4cda81d4f"
9981073
dependencies = [
9991074
"libc",
1000-
"linux-raw-sys",
1001-
"rustix",
1075+
"linux-raw-sys 0.4.14",
1076+
"rustix 0.38.40",
10021077
]
10031078

10041079
[[package]]

src/bootstrap/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ features = [
8585

8686
[dev-dependencies]
8787
pretty_assertions = "1.4"
88+
tempfile = "3.15.0"
8889

8990
# We care a lot about bootstrap's compile times, so don't include debuginfo for
9091
# dependencies, only bootstrap itself.

src/bootstrap/src/core/config/tests.rs

+171
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ use std::fs::{File, remove_file};
44
use std::io::Write;
55
use std::path::Path;
66

7+
use build_helper::ci::CiEnv;
8+
use build_helper::git::PathFreshness;
79
use clap::CommandFactory;
810
use serde::Deserialize;
911

@@ -13,6 +15,7 @@ use crate::core::build_steps::clippy::{LintConfig, get_clippy_rules_in_order};
1315
use crate::core::build_steps::llvm;
1416
use crate::core::build_steps::llvm::LLVM_INVALIDATION_PATHS;
1517
use crate::core::config::{LldMode, Target, TargetSelection, TomlConfig};
18+
use crate::utils::tests::git::git_test;
1619

1720
pub(crate) fn parse(config: &str) -> Config {
1821
Config::parse_inner(
@@ -531,3 +534,171 @@ fn test_exclude() {
531534

532535
assert_eq!(first_excluded, exclude_path);
533536
}
537+
538+
#[test]
539+
fn test_pr_ci_unchanged_anywhere() {
540+
git_test(|ctx| {
541+
let sha = ctx.create_upstream_merge(&["a"]);
542+
ctx.create_nonupstream_merge(&["b"]);
543+
let src = ctx.check_modifications(&["c"], CiEnv::GitHubActions);
544+
assert_eq!(src, PathFreshness::LastModifiedUpstream { upstream: sha });
545+
});
546+
}
547+
548+
#[test]
549+
fn test_pr_ci_changed_in_pr() {
550+
git_test(|ctx| {
551+
let sha = ctx.create_upstream_merge(&["a"]);
552+
ctx.create_nonupstream_merge(&["b"]);
553+
let src = ctx.check_modifications(&["b"], CiEnv::GitHubActions);
554+
assert_eq!(src, PathFreshness::HasLocalModifications { upstream: sha });
555+
});
556+
}
557+
558+
#[test]
559+
fn test_auto_ci_unchanged_anywhere_select_parent() {
560+
git_test(|ctx| {
561+
let sha = ctx.create_upstream_merge(&["a"]);
562+
ctx.create_upstream_merge(&["b"]);
563+
let src = ctx.check_modifications(&["c"], CiEnv::GitHubActions);
564+
assert_eq!(src, PathFreshness::LastModifiedUpstream { upstream: sha });
565+
});
566+
}
567+
568+
#[test]
569+
fn test_auto_ci_changed_in_pr() {
570+
git_test(|ctx| {
571+
let sha = ctx.create_upstream_merge(&["a"]);
572+
ctx.create_upstream_merge(&["b", "c"]);
573+
let src = ctx.check_modifications(&["c", "d"], CiEnv::GitHubActions);
574+
assert_eq!(src, PathFreshness::HasLocalModifications { upstream: sha });
575+
});
576+
}
577+
578+
#[test]
579+
fn test_local_uncommitted_modifications() {
580+
git_test(|ctx| {
581+
let sha = ctx.create_upstream_merge(&["a"]);
582+
ctx.create_branch("feature");
583+
ctx.modify("a");
584+
585+
assert_eq!(
586+
ctx.check_modifications(&["a", "d"], CiEnv::None),
587+
PathFreshness::HasLocalModifications { upstream: sha }
588+
);
589+
});
590+
}
591+
592+
#[test]
593+
fn test_local_committed_modifications() {
594+
git_test(|ctx| {
595+
let sha = ctx.create_upstream_merge(&["a"]);
596+
ctx.create_upstream_merge(&["b", "c"]);
597+
ctx.create_branch("feature");
598+
ctx.modify("x");
599+
ctx.commit();
600+
ctx.modify("a");
601+
ctx.commit();
602+
603+
assert_eq!(
604+
ctx.check_modifications(&["a", "d"], CiEnv::None),
605+
PathFreshness::HasLocalModifications { upstream: sha }
606+
);
607+
});
608+
}
609+
610+
#[test]
611+
fn test_local_committed_modifications_subdirectory() {
612+
git_test(|ctx| {
613+
let sha = ctx.create_upstream_merge(&["a/b/c"]);
614+
ctx.create_upstream_merge(&["b", "c"]);
615+
ctx.create_branch("feature");
616+
ctx.modify("a/b/d");
617+
ctx.commit();
618+
619+
assert_eq!(
620+
ctx.check_modifications(&["a/b"], CiEnv::None),
621+
PathFreshness::HasLocalModifications { upstream: sha }
622+
);
623+
});
624+
}
625+
626+
#[test]
627+
fn test_local_changes_in_head_upstream() {
628+
git_test(|ctx| {
629+
// We want to resolve to the upstream commit that made modifications to a,
630+
// even if it is currently HEAD
631+
let sha = ctx.create_upstream_merge(&["a"]);
632+
assert_eq!(
633+
ctx.check_modifications(&["a", "d"], CiEnv::None),
634+
PathFreshness::LastModifiedUpstream { upstream: sha }
635+
);
636+
});
637+
}
638+
639+
#[test]
640+
fn test_local_changes_in_previous_upstream() {
641+
git_test(|ctx| {
642+
// We want to resolve to this commit, which modified a
643+
let sha = ctx.create_upstream_merge(&["a", "e"]);
644+
// Not to this commit, which is the latest upstream commit
645+
ctx.create_upstream_merge(&["b", "c"]);
646+
ctx.create_branch("feature");
647+
ctx.modify("d");
648+
ctx.commit();
649+
assert_eq!(
650+
ctx.check_modifications(&["a"], CiEnv::None),
651+
PathFreshness::LastModifiedUpstream { upstream: sha }
652+
);
653+
});
654+
}
655+
656+
#[test]
657+
fn test_local_no_upstream_commit_with_changes() {
658+
git_test(|ctx| {
659+
ctx.create_upstream_merge(&["a", "e"]);
660+
ctx.create_upstream_merge(&["a", "e"]);
661+
// We want to fall back to this commit, because there are no commits
662+
// that modified `x`.
663+
let sha = ctx.create_upstream_merge(&["a", "e"]);
664+
ctx.create_branch("feature");
665+
ctx.modify("d");
666+
ctx.commit();
667+
assert_eq!(
668+
ctx.check_modifications(&["x"], CiEnv::None),
669+
PathFreshness::LastModifiedUpstream { upstream: sha }
670+
);
671+
});
672+
}
673+
674+
#[test]
675+
fn test_local_no_upstream_commit() {
676+
git_test(|ctx| {
677+
let src = ctx.check_modifications(&["c", "d"], CiEnv::None);
678+
assert_eq!(src, PathFreshness::MissingUpstream);
679+
});
680+
}
681+
682+
#[test]
683+
fn test_local_changes_negative_path() {
684+
git_test(|ctx| {
685+
let upstream = ctx.create_upstream_merge(&["a"]);
686+
ctx.create_branch("feature");
687+
ctx.modify("b");
688+
ctx.modify("d");
689+
ctx.commit();
690+
691+
assert_eq!(
692+
ctx.check_modifications(&[":!b", ":!d"], CiEnv::None),
693+
PathFreshness::LastModifiedUpstream { upstream: upstream.clone() }
694+
);
695+
assert_eq!(
696+
ctx.check_modifications(&[":!c"], CiEnv::None),
697+
PathFreshness::HasLocalModifications { upstream: upstream.clone() }
698+
);
699+
assert_eq!(
700+
ctx.check_modifications(&[":!d", ":!x"], CiEnv::None),
701+
PathFreshness::HasLocalModifications { upstream }
702+
);
703+
});
704+
}

src/bootstrap/src/utils/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ pub(crate) mod tracing;
2020
pub(crate) mod metrics;
2121

2222
#[cfg(test)]
23-
mod tests;
23+
pub(crate) mod tests;

0 commit comments

Comments
 (0)